scottb613, on 25 October 2021 - 03:47 AM, said:
Thanks as well. Just for clarification - we should use ORTSTenderWagonCoalMass and ORTSTenderWagonWaterMass in the WAG - omitting the parameters in the ENG file?
This feature was to allow users to add different tenders to the same locomotive without having to have different ENG files for each tender.
As a general principal I prefer a minimalist approach, ie only add a parameter if you need it, rather then adding every parameter just in case. This seems to have been the approach with MSTS stock, and sometimes it causes drama as the parameter is not relevant to the model being produced, and can cause issues.
The only downside to this approach would be if a tender is coupled to the locomotive which does not have some default coal and water values in it, then there would be none in either the tender or the locomotive.
scottb613, on 25 October 2021 - 03:47 AM, said:
And I see what threw me on your Niagara - - - I've always called my "INCLUDE" files (labeled as "*.inc") from the ENG/WAG file - - - you're calling the ENG/WAG file from the "INCLUDE" file. There's actually two ENG and two WAG files for this locomotive. Sorry I missed that when I was looking initially - just wasn't familiar with this format.
As you have pointed out elsewhere, I have created this stock for the following reasons:
Firstly I now that the feature worked with these models, and also that they should be configured "correctly", hence it confirms for me very quickly whether it is likely to be a code issue or a configuration issue.
Secondly it saves me wasting developer time. If a user can reproduce the problem with the CTN stock, then I can quickly see and experience the problem. This saves me having to search for the stock in question, and then check its configuration, etc. This all takes time, and reduces the time available to investigate the bug.
In terms of using the INC file with this type of approach, it potentially allows the base file to set up as a MSTS operation, and the INC file as a OR configuration. (However I personally think that it is time to move beyond MSTS as it has reached its 20th anniversary).