[darwins]

Sounds like a challenge. Carlo Santucci wrote the TCS script for UK AWS perhaps he can help update this. I only write eng and wag files - not yet learned how to write scripts. Where does that leave things for air brakes? Does that mean that this will be possible with a script?

ORTSDoesBrakeCutPower ( 1 )
ORTSBrakeCutsPowerAtBrakePipePressure ( 46psi )
ORTSBrakeRestoresPowerAtBrakePipePressure ( 60psi )

and what about working without a script?

[Serana]

Air brakes are also already supported for the default TCS, but the parameter is not called ORTSDoesBrakeCutPower. It is called DoesBrakeCutPower.

[Csantucci]

I am not happy with what has occurred here. As I have written also elsewhere, I am not against making changes in the core OR code that could affect existing TCS scripts, but this should be clearly announced, discussed and a balance should be publicly be drawn between changing the core OR code and changing the scrips.
In this case AFAIK nothing of the above has occurred, and the problem has been raised by an attentive OR simmer starting from the consequences of the issue.
The AWS TCS script has been downloaded 985 times from my site, and from this http://www.elvastowe...post__p__258806 I understand that there are also other download sites for the script. All this people should download a new release of the script, once I would have modified it. So I think it should be discussed if the OR code change is worth the disturbance.
Other problem: there are people that prefer using the stable release. So what? Should two versions of the script be available? Unacceptable in my opinion.

[Serana]

I just had a better idea than what I did initially: integrate the default code in the abstract class as a virtual function.
That way, the code is included in every script automatically. For custom behaviour, we just have to override this function.

Edit : Well... it's not perfect... because you still have to call it from the Update function... In order to avoid modificating scripts, I will have to call the function from outside of the script.

[darwins]

Hi,
This function is still not working when scripts are enabled. Any updates please?

[Serana]

Hi,

No changes currently.

But anyway, this functionnality should have never been implemented outside of the TCS interface. The DoesBrakeCutsPower functionnality was implemented in the TCS interface long before pull request 103 implemented it for vacuum brakes seperatedly.

[darwins]

As I am not neither a code writer nor a member of the OR Development team I am not in a position to argue about what should or should not have been done at any particular time.

As a content creator I thought that OR would stick to the matter of backwards compatibility. So often I have asked for changes to features to be told that it would break backwards compatibility with MSTS or with previous versions of OR. Right or wrong, this seems to me a case of something that was once working, that is no longer working.

[darwins]

Whilst trying to get this fixed I note that this does not work for air brakes either if scripts are enabled

DoesBrakeCutPower ( 1 )
ORTSBrakeCutsPowerAtBrakePipePressure ( 46psi )
ORTSBrakeRestoresPowerAtBrakePipePressure ( 60psi )

(As with vacuum brakes it does work if scripts are disabled.)

[Serana]

Which version of OR are you using?
Because on my side, without scripts, it works properly with similar parameters as yours.

[darwins]

I am using U2021.12.22-0406. It does work without scripts for me too. The problem is that it does not work with scripts. (For either air or vacuum brakes.)