[Haran Banjo]

 Csantucci, on 12 December 2021 - 12:45 AM, said:

Yes, it works now. Good job!

I also have the same problem with the signals, how is it solved?

[Csantucci]

I'm merging into ORNYMG Cédric's improvements with the ones that were already present there (subject to the selection of the Reduce Memory Usage option).
Doing this I noticed that I had also modified Sweep() this way within Shapes.cs

        public void Sweep()
        {
            foreach (var path in ShapeMarks.Where(kvp => !kvp.Value).Select(kvp => kvp.Key))
            {
                var shape = Shapes[path];
                Shapes.Remove(path);
                if (Viewer.Settings.ReduceMemory)
                {
                    foreach (var lod in shape.LodControls)
                        for (var subObjectIndex = 0; subObjectIndex < lod.DistanceLevels[0].SubObjects.Length; subObjectIndex++)
                            foreach (var prim in lod.DistanceLevels[0].SubObjects[subObjectIndex].ShapePrimitives)
                                prim.VertexBuffer.Dispose();
                    shape = null;
                }
            }
        }

I wonder whether this can be of interest.

[gpz]

As I glanced into the code, these all should actually be IDisposables (the Shape, LodControl, DistanceLevel, Subobject, ShapePrimitive), because the lowest level ShapePrimitive has two disposable members: the VertexBuffer and the Indexbuffer. (Carlo, you might have also needed to dispose the latter: prim.IndexBuffer.Dispose(); )

And the call would be simply

var shape = Shapes[path];
Shapes.Remove(path);
shape.Dispose();

, and it would roll down by the chain.

[Csantucci]

Thanks Peter,
C# does not like shape.Dispose(), because it doesn't find the method. Instead I could add prim.IndexBuffer.Dispose();.

[gpz]

I mentioned the shape.Dispose(), because that would be the "clean" implementation. All of the classes in the chain must implement the IDisposable interface, and all of them implement the Dispose() method, which calls all the member's own Dispose(). The basic thumb-rule is that every class has to implement the IDisposable interface that has at least one IDisposable member.

[Csantucci]

OK, I see.
I have now performed the merge as described here http://www.elvastowe...post__p__279251 , and this is available in ORNYMG rev. 112. In ORNYMG the feature requires the general option Reduce Memory Usage to be checked; the requirement will probably be removed when the feature will become tested enough.

[Csantucci]

A user reports a crash in the Loading screen dispose, because his test route has no loading screen...

[Serana]

Ok, I will add a null-conditional operator to this.

[akioyamamura]

I'm trying the "reduce memory usage" feature, and having a minor problem with the ACCELEROMETER. As you can see in the video the accelerometer it's working fine until 3:37 and than he disappear, when it's need to show the positive value. It's happens in every path that I tried and sometimes the negative value disappear too. Deactivating the "reduce memory usage" everything works again. Just to clarified the accelerometer number are highlighted in the printscreen attched.
Tested with 32 bits box checked too, but the problem persists.
Thank you.

https://youtu.be/VlRMdvr8hus

Attached File(s)

•  OpenRailsLog.txt (59.77K)
  Number of downloads: 2
•  Open Rails 2021-12-21 10-09-51.jpg (397.59K)
  Number of downloads: 0

[Serana]

 Csantucci, on 17 December 2021 - 01:23 AM, said:

I'm merging into ORNYMG Cédric's improvements with the ones that were already present there (subject to the selection of the Reduce Memory Usage option).
Doing this I noticed that I had also modified Sweep() this way within Shapes.cs

        public void Sweep()
        {
            foreach (var path in ShapeMarks.Where(kvp => !kvp.Value).Select(kvp => kvp.Key))
            {
                var shape = Shapes[path];
                Shapes.Remove(path);
                if (Viewer.Settings.ReduceMemory)
                {
                    foreach (var lod in shape.LodControls)
                        for (var subObjectIndex = 0; subObjectIndex < lod.DistanceLevels[0].SubObjects.Length; subObjectIndex++)
                            foreach (var prim in lod.DistanceLevels[0].SubObjects[subObjectIndex].ShapePrimitives)
                                prim.VertexBuffer.Dispose();
                    shape = null;
                }
            }
        }

I wonder whether this can be of interest.

This is indeed interesting, I will introduce something similar, but with the refactoring proposed by Peter.