[Csantucci]

Mervyn (copperpen) is right. The same occurs to me with the Gölsdorf.

[jonas]

Good news in a way: I have tested it on another PC (Win7) with version X3517 and there is no bug, the chuff sound shuts off with the closed throttle, as with you. The error occurs on my main computer with WinVista. I will make further tests on other computers during the day and then I will report here again. Thank you for your time and patience so far.

[jonas]

I've made a series of tests today about the chuff sound with 11 versions of OR on 3 different computers each. The result can be seen in the table below.

"OK" means that on running locomotives and closed throttle the chuff sound is turned off. "No" means you can hear the chuff sound continuously after closing the throttle (bug):

In the bold column left, my main computer can be seen, why I became aware of the bug. Since version X3513 on my WinVista and WinXP computer the bug is present.

Hard to say for me whether it is up to the PC itself or the operating system. Intressting that on the win7 machine the version X3507 to X3510 shows the bug too.

[jonas]

I have tested a fourth computer, an old DELL 2.0 GHz with winXP (right column). Surprisingly, it's working fine like the win7 computer (second column), where the bug occurs with versions X3507 to X3510, but not with one of the current versions X3519.



Now I think it is clearly not a matter of the OS but a hardware problem, probably the sound card. Anyway, since version X3513 ("adjusted friction coeff calculations,...") the bug on some computers happens.

Is there any interest that I test further computers concerning to this bug?

[copperpen]

Not quite sure how adjusting friction coeff calculations has an effect on sounds controlled by the throttle, beyond them sounding faster when wheelslip happens.

[jonas]

Yes, I'm with you copperpen.

Please, can someone name the concerning *.cs file(s) of the source code, where the throttle is controlled?

[jonas]

I think I've figured it out. It has nothing to do with the hardware of different computer or the operating system. The bug occurs when the option "advanced adhesion model" is deselected. The Variable1 depends on the wheel speed and this is only calculated if the "advanced adhesion model" is active.

How I have found it:

1. in Sound.cs at line 1715 in case of variable1 trigger Variable1_Inc_Past the line return car.Variable1; is selected. But car.Variable1 was always 0 while debugging.

2. in MSTSSteamLocomotive.cs at line 1635 car.Variable1 is calculated by using WheelSpeedMpS:
Var variable1 = WheelSpeedMpS / DriverWheelRadiusM / MathHelper.Pi * 5;
But WheelSpeedMpS was always 0 while debugging.

3. in MSTSSteamLocomotive.cs from line 3684 WheelSpeedMpS is calculated only if (Simulator.UseAdvancedAdhesion) // only set slip when advanced adhesion is set.

So I suggest to insert an else statement at line 3746 where "WheelSpeedMpS" gets a value different from 0, if "advanced adhesion model" is off.

Thanks to Carlo for the support finding relevant code lines.

Best regards
jonas

[steamer_ctn]

jonas, on 25 April 2016 - 01:12 PM, said:

I think I've figured it out. It has nothing to do with the hardware of different computer or the operating system. The bug occurs when the option "advanced adhesion model" is deselected. The Variable1 depends on the wheel speed and this is only calculated if the "advanced adhesion model" is active.

Hopefully it is now corrected in #3531.

Thanks for the effort to debug the problem.

[Csantucci]

jonas,
thanks to you for your contribution.

[jonas]

I'm happy since #3531. Closed throttle mutes variable1 controlled chuff sound while loco is driving now again, with and without "advanced adhesion model".

Thanks to steamer_ctn for fixing it promtly!