[avatrain1]

From version x2534 and higher can no longer hear the signal of departure of the train.

Regards,
Sergio.

[Csantucci]

avatrain1, on 29 September 2014 - 01:23 PM, said:

From version x2534 and higher can no longer hear the signal of departure of the train.

Regards,
Sergio.

Provisionally fixed in x2541. Changing WorldLocation from class to structure has consequences also within files where WorldLocation was compared to null, like Sound.cs.
Peter, pls. check if the patch is OK.

[dennisat]

avatrain1, on 29 September 2014 - 01:23 PM, said:

From version x2534 and higher can no longer hear the signal of departure of the train.

I've noticed this as well. I think it's due to the definition "WorldLocation WorldLocation;" in sound.cs. I have renamed this to "WorldLocation World_Location;" and the ready to start noises are now audible again. However, although it all seems to be working, I've not done enough testing to check whether something else has now gone wrong as a result of my change.

Dennis

Behind the curve I see!! I renamed it so that there wasn't so much confusion as well as changing null to WorldLocation.None.

[James Ross]

Csantucci, on 30 September 2014 - 05:45 AM, said:

Provisionally fixed in x2541. Changing WorldLocation from class to structure has consequences also within files where WorldLocation was compared to null, like Sound.cs.
Peter, pls. check if the patch is OK.

Sorry about that, and the Track Viewer breakage; the compiler spotted lots of nulls used for WorldLocation but apparently isn't so sensitive on null comparisons with value types. I'll see if I can find any other comparisons with null this evening.

[copperpen]

Could those changes have also caused this http://www.elvastowe...nd-of-activity/

[James Ross]

James Ross, on 30 September 2014 - 06:27 AM, said:

Sorry about that, and the Track Viewer breakage; the compiler spotted lots of nulls used for WorldLocation but apparently isn't so sensitive on null comparisons with value types. I'll see if I can find any other comparisons with null this evening.

It took a few hours, and I only found two issues (in Cameras.cs), but I think that's all the WorldLocation stuff done.

[James Ross]

copperpen, on 30 September 2014 - 11:45 AM, said:

Could those changes have also caused this http://www.elvastowe...nd-of-activity/

I don't think so, but please try out other versions to figure out when it broke.

[copperpen]

Well, X2533 gives the normal platform activity finished, you may depart. X2534 gives the same message immediately followed by Activity Complete. The Eugene stop is the only passenger stop and is followed in the activity file by the activity complete code that includes the world location.