[James Ross]

New fog code in X1948. I included some fogging of the sky but I'm not sure it's working that well.

[Csantucci]

James,
thanks for being involved in that. I made a short test and found two issues:
1) From following picture, taken with maximum fog, I don't see fog effects on the sky, while I like the effects of the signal lights and how the station can be seen

2) When pressing for very short time the key to reduce fog, the fog reduces very much. This is the effect

So the steps for fog intensity are too high when fog is intense in my opinion.

[railguy]

I really like BB25187's effects. How do they look at night? Also, are those "stock" OR clouds in the screenshots or modified textures?

[BB25187]

Hi James,

Thanks for the update.
This is funny: I also tried to adapt the sky to the fog density! Besides the sky, I found out that fog should also impact the clouds. Otherwise the horizon remain visible when the weather is cloudy.

Regards

[James Ross]

Csantucci, on 19 January 2014 - 07:33 AM, said:

1) From following picture, taken with maximum fog, I don't see fog effects on the sky, while I like the effects of the signal lights and how the station can be seen
2) When pressing for very short time the key to reduce fog, the fog reduces very much. This is the effect
So the steps for fog intensity are too high when fog is intense in my opinion.

The sky is really hard to adjust because of the way it applies clouds; they don't get fogged nearly as much as the sky behind them.

The fog steps are small but also not meant to be adjusted manually (none of the weather is, really). When you have a range from 10m to 10km, good luck getting control that people like. :(

[BB25187]

Hi,

railguy, on 19 January 2014 - 07:34 AM, said:

I really like BB25187's effects. How do they look at night? Also, are those "stock" OR clouds in the screenshots or modified textures?

As for the fog at night, I think there is still room for improvements: the aspect is a bit too dark.
And yes my screenshots above make use of a modified cloud texture.

Csantucci, on 19 January 2014 - 07:33 AM, said:

I made a short test and found two issues:
1) From following picture, taken with maximum fog

Yes, I think an additional attenuation of the cloud texture is necessary when flog increases. Here is what I get on my side with a slightly different code (based on revision #1946): link to a video (video is available as Full HD. For this you must use full screen view at the bottom right of the video frame).

Regards

[Csantucci]

BB25187, on 19 January 2014 - 09:22 AM, said:

... Here is what I get on my side with a slightly different code (based on revision #1948): link to a video (video is available as Full HD. For this you must use full screen view at the bottom right of the video frame).

Regards

Thanks, your version seems to me more gradual in fog density increase and decrease.

[BB25187]

Hi Carlo

Csantucci, on 19 January 2014 - 09:41 AM, said:

Thanks, your version seems to me more gradual in fog density increase and decrease.

Maybe the things I should do are the following then:
- Update my setup at revision #1949. I will have various conflicts to resolve, because I modified the same pièces of code as James.
- Send to you the resulting patch.
I will try to find some time in the coming days to do this...

Regards
Vincent

[Csantucci]

Bonsoir Vincent, I will be glad to compare the two versions.

[BB25187]

Hi Carlo,

Csantucci, on 19 January 2014 - 01:02 PM, said:

Bonsoir Vincent, I will be glad to compare the two versions.

I created the patch from revision #1947, meaning it doesn't contain the changes made by James - this was easier for me because it didn't create any conflict. Several things are still missing in my code: stars and moon are not impacted by fog, whereas they should. Furthermore my implementation of the sky fading is a bit crappy and should be cleaned up. Anyway: it will allow you to compare the two methods. I am sure that the revision #1948 by James is a good basis and only needs minor changes.
I hope it helps,

Regards
Vincent

Attached File(s)

•  Patch_FogSky_Rev1947.zip (1.32K)
  Number of downloads: 195