[dforrest]

Has U2020-10-16-2036 caused steam locos to emit technicolor smoke?

[copperpen]

It has for me, and in addition vitrually every surface of scenery and train have a speckly shimmer.

Video is Nvidia GT 1050

[Traindude]

Not just the steam loco emmitters whose colors are wrong and garbled. Also note the oversized snowflakes. NVIDIA GeForce GT 710.

[Lamplighter]

The same bug is in the previous update. I prefer to go back to the version from 13.10.2020
It has such a punk ambience ;-)

[Hobo]

I also agree that 2020.10.13-0436 is the last version that has proper colours . The steam locos look like they're burning sulphur instead of coal and black steam from cylinders etc . for the later versions .

[Csantucci]

In U2020.10.16-2036 a new porting to Monogame has been introduced. I assume that this has created the problem. Also in the preceding porting to Monogame (the one in OR NewYear MG) this problem arose and was solved. IIRC the coding sequence of the colour components has changed in Monogame.

[dforrest]

Will this be fixed soon?

[jared2982]

Smoke color is still an issue in U2020.10.21-1851

[YoRyan]

Csantucci, on 19 October 2020 - 01:09 AM, said:

Also in the preceding porting to Monogame (the one in OR NewYear MG) this problem arose and was solved.

Carlo, could you describe the fix you made for this issue?

[Csantucci]

I'm sorry, but I can't be of big help. At that time (October 2017) I used Tortoise SVN to update OR MG, and so I'm not able to get the story of the changes. I suppose that the problem has a relationship to this

Index: Orts.Formats.Msts/LightCollection.cs
===================================================================
--- Orts.Formats.Msts/LightCollection.cs	(revision 3960)
+++ Orts.Formats.Msts/LightCollection.cs	(working copy)
@@ -52,6 +52,14 @@
                 new STFReader.TokenProcessor("transition", ()=>{ Transition = 1 <= stf.ReadFloatBlock(STFReader.UNITS.None, 0); }),
                 new STFReader.TokenProcessor("angle", ()=>{ Angle = stf.ReadFloatBlock(STFReader.UNITS.None, null); }),
             });
+            // Color byte order changed in XNA 4 from BGRA to RGBA
+            Color = new Color()
+            {
+                B = (byte)(Color),
+                G = (byte)(Color >> 8),
+                R = (byte)(Color >> 16),
+                A = (byte)(Color >> 24)
+            }.PackedValue;
         }
 
         public LightState(LightState state, bool reverse)

that Peter already noticed and corrected for lights, but I'm not sure.
Here http://www.elvastowe...post__p__226424 I mention the issue.

If you read just subsequently in that thread, you will notice also the pixellation effect bug, that seems the same reported in another bug thread here.
Reading further in the thread, pixellation seems to have been solved here by Dennis http://www.elvastowe...post__p__228355 .

[James Ross]

dforrest, on 17 October 2020 - 11:21 AM, said:

Has U2020-10-16-2036 caused steam locos to emit technicolor smoke?

Yes, it appears so.

Csantucci, on 19 October 2020 - 01:09 AM, said:

In U2020.10.16-2036 a new porting to Monogame has been introduced. I assume that this has created the problem. Also in the preceding porting to Monogame (the one in OR NewYear MG) this problem arose and was solved. IIRC the coding sequence of the colour components has changed in Monogame.

Yes, this is the new MonoGame version.

When we encounter an issue that you remember being fixed previously, if you are able, it would be helpful if you could find that fix. I don't want to duplicate the work of fixing these kinds of problem if I can help it. :)

Csantucci, on 24 October 2020 - 01:03 AM, said:

that Peter already noticed and corrected for lights, but I'm not sure.
Here http://www.elvastowe...post__p__226424 I mention the issue.

Yes, we've got the correction for lights. Thanks for the link to the post, which gives me a period to search your code to find the fix.

Csantucci, on 24 October 2020 - 01:03 AM, said:

If you read just subsequently in that thread, you will notice also the pixellation effect bug, that seems the same reported in another bug thread here.
Reading further in the thread, pixellation seems to have been solved here by Dennis http://www.elvastowe...post__p__228355 .

Ah, great, thanks! I will put down a review of all the shader warnings in case there's other problems lurking in there like this one.

[dennisat]

Hi,

I have been watching these problems and, knowing that I'd previously found solutions to some of them, have been trying to untangle them from my poorly documented system. I'd forgotten that some of the patches might still be found on these forums.

Dennis

[dennisat]

dennisat, on 25 October 2020 - 08:57 AM, said:

HI have been watching these problems and, knowing that I'd previously found solutions to some of them, have been trying to untangle them from my poorly documented system. I'd forgotten that some of the patches might still be found on these forums.

Incidentally, the solution to the football sized snow drops is this:

 Source/RunActivity/Viewer3D/Precipitation.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Source/RunActivity/Viewer3D/Precipitation.cs b/Source/RunActivity/Viewer3D/Precipitation.cs
index 9c177d8e2..a4d620f77 100644
--- a/Source/RunActivity/Viewer3D/Precipitation.cs
+++ b/Source/RunActivity/Viewer3D/Precipitation.cs
@@ -520,7 +520,7 @@ public override void SetState(GraphicsDevice graphicsDevice, Material previousMa
                 shader.precipitation_Tex.SetValue(DynamicPrecipitationTexture[precipitation_TexIndex]);
             }
 
-            graphicsDevice.BlendState = BlendState.AlphaBlend;
+            graphicsDevice.BlendState = BlendState.NonPremultiplied;
             graphicsDevice.DepthStencilState = DepthStencilState.DepthRead;
         }
 

Dennis

[James Ross]

dennisat, on 25 October 2020 - 09:08 AM, said:

Incidentally, the solution to the football sized snow drops is this:

Fantastic, thanks! This is fixed in U2020.10.25-2351.

The smoke colour will take a little longer as I need to find the fix in the git history.

[Csantucci]

OK,
by checking with Notepad++ the differences in ParticleEmitter.cs between Peter's original version and the actual OR NewYear MG I found the patch needed to get correct exhaust colors. Here it is
 ParticleEmitter.cs.patch.txt (1.33K)
Number of downloads: 525
Dennis, do you remember if this too was your finding?