Lamplighter, on 12 March 2020 - 10:43 AM, said:
Hi,
I do not understand why the Exhaust1 (Exhaust2) parameters are only listed as MSTS. Open Rails uses the DieselSpecialEffects parameter and cannot do without the above.
You are absolutely right, multiple exhausts can be defined with OR. It's a question of how.
There are no input parameters specifically named "Exhaust1" or "Exhaust2". The TokenID.cs listing includes the specific labels "Exhaust1" or "Exhaust2" which don't exist as specific input parameters in OR. The "OR TokenID.cs Comparison" sheet is looking specifically at the original list of MSTS tokens and determining which of these MSTS tokens still exist in OR.
"exhaust" is a new parameter introduced in OR and is present in the "OR Code Parameters" column on sheet "Parameter Comparison".
OR enables multiple exhaust entries in a much better way using this input called "exhaust". In looking closer at how this parameter is read, the statement is "where blah, blah.
StartsWith(''exhaust'')", the operative word being "
startswith". So as many instances of exhaust can be defined as required. I'm not sure if what follows "exhaust" even needs to be a number. I'll check this out at some point.
I missed this subtlety. Technically "Exhaust1", etc. is an OR parameter but is not directly read as such so I need to find a way to catch any additional instances like this and make sure there is no confusion. "startswith" is also used in MSTSNotchControllers so it looks like a number of "enginebrakescontroller . . ." and "trainbrakescontroller . . . " tokens which are showing up as MSTS only need to be looked at more closely.
Thanks for raising this issue.