gpz, on 22 April 2025 - 05:17 AM, said:
In my opinion nothing is up with it, it is ready to be merged. I honestly don't understand the concern about specifically the animation implemented in gltf. If I'd be the reviewer, I'd focus more on the lighting/shader part, since that one is a much bigger change with a much bigger impact. (@mention ORMT here)
I think we have opposite concerns here, then; I can see maybe three distinct areas of work here:
- Model rendering
- Animation playback
- Animation control by simulation
Points 1 and 2 are (I assume) entirely covered by the glTF specifications and, if we have a mistake here, people will see something behave differently to other glTF tools, which would clearly make it a bug in Open Rails that we are expected to fix.
However, point 3, which refers to things like how the animation sequence for doors in a train car model is controlled by the simulation when triggering opening/closing, is entirely our own thing, not defined by any specification and it is not exactly the same as MSTS (which uses frames instead of time IIRC).
I see this leading to two potential issues:
- Which animations play by default, and which don't
- Which animations are controlled by the simulation, and how exactly that works
In both cases, we may not be able to fix any problems with how these are defined, once we have released this and people have started making models. Some things could be fixed, relaxed, or extended, but only if we keep them sufficiently contained to start with.
That's why I would like us (the whole project) to carefully review how the animations are controlled for glTF but am a lot less worried about the model rendering and animation playback itself.
I hope that helps explain why there is a concern, even if you don't share it.