Elvas Tower: Updated contributing guideines for refactoring - Elvas Tower

Jump to content

Posting Rules

All new threads will be started by members of the Open Rails team, Staff, and/or Admins. Existing threads started in other forums may get moved here when it makes sense to do so.

Once a thread is started any member may post replies to it.
Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Updated contributing guideines for refactoring Rate Topic: -----

#1 User is offline   James Ross 

  • Open Rails Developer
  • Group: Status: Elite Member
  • Posts: 5,491
  • Joined: 30-June 10
  • Gender:Not Telling
  • Simulator:Open Rails
  • Country:

Posted 20 January 2024 - 05:03 AM

It came to my attention that refactoring PRs, of which we have had a number over the years, are generally welcomed but had no place in the contribution guidelines (not a bug, not a feature, etc.), so I have added an explicit process for refactoring changes.

The process is the same as for other PRs which don't have a bug report or feature request - all code is still to be reviewed, including checking against any architectural documentation, but no bug report or feature request is necessary to go with it.

This should match what has been happening in practice so it is really just putting the reality into the documentation.

You can view the pull request or the updated page directly.
Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users