[Csantucci]

A recent change in the Advanced Adhesion code has disrupted Cruise Control operation, see here https://www.elvastow...post__p__304556 and subsequent posts.
Here is the code of the patch that solved the issue in ORNYMG
 adhesionpatch1.diff.txt (769bytes)
Number of downloads: 41
Cruise Control needs WheelSpeedMpS to monitor the speed of the controlled locomotive.
The author of the Advanced Adhesion code might use this patch or a similar one to solve the issue also in the official OR versions.

[steamer_ctn]

Csantucci, on 12 January 2024 - 06:26 AM, said:

A recent change in the Advanced Adhesion code has disrupted Cruise Control operation, see here https://www.elvastow...post__p__304556 and subsequent posts.

Thanks for identifying this, and providing a suggested solution.

Can you confirm which "official" OR versions that the fault appears in?

[Csantucci]

This started with your commit abbd3b136bd975eba34 "Correct throttle operation", and is caused by the deletion of some code lines in MSTSLocomotive.cs. As your PR isn't yet merged, the Testing version is not affected at the moment.

[steamer_ctn]

Csantucci, on 14 January 2024 - 01:29 AM, said:

This started with your commit abbd3b136bd975eba34 "Correct throttle operation", and is caused by the deletion of some code lines in MSTSLocomotive.cs. As your PR isn't yet merged, the Testing version is not affected at the moment.

Thanks for clarifying that.

I was wondering how it had got past the Unstable version, especially as it seemed to be in ORNYMG, but this explains that it hadn't got past.

[Csantucci]

I have merged your PR into ORNYMG even if your PR isn't merged into master, as it corrected a steam locomotive problem I wanted to get rid.

[steamer_ctn]

Csantucci, on 14 January 2024 - 02:05 AM, said:

I have merged your PR into ORNYMG even if your PR isn't merged into master, as it corrected a steam locomotive problem I wanted to get rid.

Aah, that explains it.