[Hannes44]

Since some iterations ago I cannot resume saved games any more. There is an "Error: System.IO.InvalidDataException: Invalid controller type". There is no change of locomotive data or any other data. I don't understand what "invalid controller type" should mean, because I drove the loco until the save without a problem, saved, reloaded immediatly, but no luck.

It happens with the Testing version and the Unstable version.

Attached File(s)

•  OpenRailsLog.txt (25.1K)
  Number of downloads: 71

[engmod]

This loco has a problem that you need to fix.

Desiro_OEBB_Rh5022_2kl.eng

There is a brace missing and its causing OR to miss some lines after the missing brace.
If you are unable to fix the problem, attach the file here and someone will fix it for you.

[Hannes44]

I checked the desiro filr for wrong brackets but couldn't find anything. I attach the *.eng file; could someone more knowledgeable than me have a look at it, please?

Attached File(s)

•  Desiro_OEBB_Rh5022_2kl.eng (22.12K)
  Number of downloads: 70

[Kapitaen13]

Hallo Hannes,
ich habe den Soundeintrag weiter vor gesetzt und das °C bei der Temperatur entfernt.
Es gibt da noch einen weiteren Fehler: Warning: C:\ORStrecken\Hauptbahnen\Trains\trainset\ZOS Eaos\mavc_eaos_fa.wag references non-existent shape C:\ORStrecken\Hauptbahnen\Trains\trainset\ZOS Eaos\fa1.s
Das heißt, dass in mavc_eaos_fa.wag das nicht vorhandene shape fa1.s eingetragen ist.

Attached File(s)

•  Desiro_OEBB_Rh5022_2kl.eng (22.12K)
  Number of downloads: 68

[Hannes44]

Thank you und danke for the suggestions, I corrected all of my desiro files, but the problem persists. The error re 5022 is gone now but "Invalid controller type" brings ORTS down.

Attached File(s)

•  OpenRailsLog.txt (24.79K)
  Number of downloads: 59

[engmod]

Engine controllers should look like this:-

EngineControllers (
Throttle ( 0 1 0.125 0
NumNotches ( 9
Notch ( 0 0 Dummy )
Notch ( 0.125 0 Dummy )
Notch ( 0.25 0 Dummy )
Notch ( 0.375 0 Dummy )
Notch ( 0.5 0 Dummy )
Notch ( 0.625 0 Dummy )
Notch ( 0.75 0 Dummy )
Notch ( 0.875 0 Dummy )
Notch ( 1 0 Dummy )
)
)
Brake_Engine ( 0 1 0.2 0
NumNotches ( 2
Notch( 0 0 EngineBrakesControllerReleaseStart )
Notch( 0.3 1 EngineBrakesControllerGraduatedSelfLapLimitedStart )
)
)
Brake_Train ( 0 1 0.02 0
NumNotches ( 5
Notch( 0 0 TrainBrakesControllerReleaseStart )
Notch( 0.3 1 TrainBrakesControllerGraduatedSelfLapLimitedStart )
Notch( 0.85 0 TrainBrakesControllerSuppressionStart )
Notch( 0.9 0 TrainBrakesControllerContinuousServiceStart )
Notch( 0.95 0 TrainBrakesControllerEmergencyStart )
)
)
Brake_Dynamic ( 0 1 0.05 0
NumNotches ( 0 )
)
DirControl ( -1 0 1 1 )
BellToggle( 0 1 0 )
AWS ( 0 1 0 )
Sanding ( 0 1 0 )
Horn ( 0 1 0 )
Wipers ( 0 1 0 )
EmergencyStopResetToggle( 0 1 0 )
EmergencyStopToggle( 0 1 0 )
Vigilance ( 0 1 0 )
Headlights ( 0 0.25 1 0 )
)


Yours is this:-

EngineControllers (
BellToggle ( 0 1 0 )
Brake_Dynamic ( 0 1 0.04 0
NumNotches ( 1
Notch ( 0 1 Dummy )
)
)
Brake_Engine ( 0 1 0.03 0
NumNotches ( 1
Notch ( 0 1 Dummy )
)
)
Brake_Train ( 0 1 0.03 0
NumNotches ( 5
Notch ( 0 0 TrainBrakesControllerReleaseStart )
Notch ( 0.3 1 TrainBrakesControllerGraduatedSelfLapLimitedHoldingStart )
Notch ( 0.85 0 TrainBrakesControllerSuppressionStart )
Notch ( 0.9 0 TrainBrakesControllerContinuousServiceStart )
Notch ( 0.95 0 TrainBrakesControllerEmergencyStart )
)
)
Throttle ( 0 1 0.03 0
NumNotches ( 1
Notch ( 0 1 Dummy )
)
)
Combined_Control ( 0 1 0.5 0.5 throttle dynamic )
EmergencyStopToggle ( 0 1 0 )
EmergencyStopResetToggle ( 0 1 0 )
Headlights ( 0 0.25 1 0 )
Horn ( 0 1 0 )
Sanding ( 0 1 0 )
Vigilance ( 0 1 0 )
Wipers ( 0 1 0 )
)


I suggest this is causing the problem:-

BellToggle ( 0 1 0 )
Brake_Dynamic ( 0 1 0.04 0
NumNotches ( 1
Notch ( 0 1 Dummy )
)
)

[Kapitaen13]

Weter, on 13 April 2023 - 10:32 AM, said:

Hello.
120°C
Are these units defined right?

Yes, the °C result in the following message:

Warning: Found a suffix '°c' which could not be parsed as a Temperature unit in .....Desiro_OEBB_Rh5022_2kl.eng:line 293

According to log.txt from #5, the leading vehicle is now westbahn:REX_4410 and .timetablelist-or is used. It is not clear which vehicle triggers the invalid controller type.

[Hannes44]

The player loco is OEBB 4024 the Talent EMU. But this EMU is and has been used for many trains driving on my route either as AI trains or as player trains, there was never a problem saving and resuming a game. The DMU 5022 run on my route without problems for years, too. What could have changed around end of March, because that's the time since when I can't resume games any more (could be earlier though, because I was away from my computer from January to mid-March), and that's why I thought of a maybe newly introduced bug in ORTS.
I attach the 4024 and the 6024 files, because I don't know which is the leading part in this case, these EMUs change direction and are transfered to different services multiple times. Maybe I overlooked something in the *.eng files or it could be a bug?

Attached File(s)

•  6024.eng (23.85K)
  Number of downloads: 70
•  4024.eng (19.08K)
  Number of downloads: 58

[Kapitaen13]

Both .eng files run without an error message. You can also check this yourself by briefly putting the train into explore mode and then looking at the OpenRailsLog.txt.
The error must therefore come from another train composition, unfortunately the log.txt says nothing about this, sorry.

[Hannes44]

Kapitaen13, on 14 April 2023 - 01:30 AM, said:

Both .eng files run without an error message. You can also check this yourself by briefly putting the train into explore mode and then looking at the OpenRailsLog.txt.
The error must therefore come from another train composition, unfortunately the log.txt says nothing about this, sorry.