ORTS extended friction test
#1
Posted 18 April 2020 - 10:58 PM
Feel free to make some experiments with those new lines and share your experience.
[attachment=103671:ORTS_extended_friction.zip]
#2
Posted 30 April 2020 - 05:31 AM
README for new starting friction equation - by NickonWheels First and foremost, the three Davis lines ORTSDavis_A ORTSDavis_B ORTSDavis_C work as before. However now it is POSSIBLE to replace ORTSBearingType with ORTSStandstillFriction - the amount of static friction / defaults to newton but can use pounds, just like ORTSDavis_A ORTSMergeSpeed - the speed at which low speed calculations and Davis equations meet (while accelerating and decelerating) / uses meters per second, other units are untested The older code section uses 5mph as merge speed throughout. If you don´t want to bother with this new section ORTSBearingType (or lack thereof in regards to plain bearings) still works as before. Of course it´s hard to know what values seem to fit as FCalc won´t tell that.
#4
Posted 06 May 2020 - 01:13 PM
Your solution is nice and simple, does just what I want, and for those who still want to have the old friction setup, it doesn't change anything. I think that can keep everyone happy, so long as we don't start complaining about the starting friction anyone else uses! Hoping we can see this feature mainlined soon. I'll spend some time implementing this in my existing .inc files.
#5
Posted 06 May 2020 - 01:28 PM
Quoting from this thread >>> http://www.elvastowe...friction-value/
wacampbell, on 29 April 2020 - 09:16 AM, said:
MatarazzoT, on 29 April 2020 - 03:20 PM, said:
Cheers,
Thiago
steamer_ctn, on 29 April 2020 - 09:13 PM, said:
Starting resistance is not a well documented area of railway operation, and hence putting huge amount of effort into trying to find, or make up some values for it seems like a lot of effort, potentially without a great deal of return.
So in order to determine whether it is worth the time and effort to make adjustments, etc, a test scenario should be designed using real world data and see whether OR performs the same as the real world situation. If it doesn't, then this will support the case for changes to OR to be considered.
I will be able to take some of these test results into the work that I am doing on Advanced couplers.
So...it appears work is moving along, in an orderly manner.
#6
Posted 06 May 2020 - 10:02 PM
Unfortunately there is just little enthusiasm to include this code extension into the official code for unknown reasons. Sure it fixes everything and sure we should not complain about the values of others as many of us have to fix wag/eng files anyway before any serious railroading. It´s no great deal for the official code, just copy and paste/replace and a little bit updating the manual; feels a bit odd this being too much 'effort' compared to what it actually took to make this code extension so far.
BTW this version only adresses definable starting friction for static weights which most vehicles use; always planned to extend it to ORTS weight-dependent friction as well, i.e. tenders.
#7
Posted 08 May 2020 - 10:03 AM
#8
Posted 08 May 2020 - 11:36 AM
NickonWheels, on 06 May 2020 - 10:02 PM, said:
Unfortunately there is just little enthusiasm to include this code extension into the official code for unknown reasons. Sure it fixes everything and sure we should not complain about the values of others as many of us have to fix wag/eng files anyway before any serious railroading. It´s no great deal for the official code, just copy and paste/replace and a little bit updating the manual; feels a bit odd this being too much 'effort' compared to what it actually took to make this code extension so far.
BTW this version only adresses definable starting friction for static weights which most vehicles use; always planned to extend it to ORTS weight-dependent friction as well, i.e. tenders.
I don't think that is quite fair on the developers. It has been stated that this is a grey area with not much information to work on. Right now the OR train acts as one solid block, no coupler slack to use when getting a train on the move. First we need proper working slack action, then some testing to see where we are at with current starting friction, and where possible compare results with what happens in the real world.
#9
Posted 08 May 2020 - 11:21 PM
copperpen, on 08 May 2020 - 11:36 AM, said:
Slack action works reasonable right now, but this is not the point. Real world data are only useful when someone can put them in, which is principally only possible with the extended code. The thing not fair on us ORTS users is to be forced on ORTSBearingType and the calculations behind it. As said, the code extension is readily available, if you ask me I would upload it here.
I just reworked MLT´s old Bridge Line which mostly works on a self-compiled 2GB version; now I was finally able to actually accelerate cars with plain bearings..... and to overcome most of the remaining starting friction by bunching up the couplers as you told. Both this is more or less impossible with the current system but from evaluating real life switching moves (watching YouTube videos) it´s indeed possible in reality.
#10
Posted 15 May 2020 - 08:05 AM
Here it is, who ever wants do deal with it.
#11
Posted 16 May 2020 - 02:45 AM
NickonWheels, on 15 May 2020 - 08:05 AM, said:
Thanks for making this contribution.
I've downloaded it and will check it out. If it fits in with the other ORTS parameters, then I'll package it up and add it to the Unstable version of Open Rails so that it can get wider exposure.
If you have more good ideas, then it would be worthwhile using GitHub to submit your contributions in the same way as other coders.
#12
Posted 16 May 2020 - 08:30 AM
According to numerous test runs with the private version it works perfectly and in conjunction with the Davis lines already established, also positive feedback.
Maybe I should figure out GitHub for more trials.
#13
Posted 04 June 2020 - 12:27 PM
I have some interest in this feature, so I've pulled it into my GitHub repository and will submit a pull request for mainline inclusion after I've completed some refactoring and cleanup.
In the future, to make your contributions easier to merge into the master branch, please use Git for version control instead of sharing customized versions of files. Your MSTSWagon.cs file was dated from February, so I had to manually merge in changes that have been made to that file since then.
#14
Posted 04 June 2020 - 11:10 PM
I´m running back and forth about joining GitHub myself, have currently no experience with this and not wanting to mess the main code up by accident. I also sill have the fear of someone else removing such code changes because they think it´s unnecessary. If you know the formula to main code changes I´m very thankful.
#15
Posted 04 June 2020 - 11:55 PM
The good news is that there's a well-defined process: You submit a pull request, or a set of proposed changes, that you have the ability to revise, and that the core team can approve or reject. So, mistakes are easily caught and aren't permanent. And nobody else will break or revoke a feature without going through peer review first.
(By the way, I am not a core developer either, but I will try my best to integrate and advocate for this feature. :) )