Elvas Tower: Letterboxing for 2D cabs - Elvas Tower

Jump to content

  • 4 Pages +
  • 1
  • 2
  • 3
  • 4
  • You cannot start a new topic
  • You cannot reply to this topic

Letterboxing for 2D cabs Proposal and patch Rate Topic: -----

#21 User is offline   Csantucci 

  • Member, Board of Directors
  • Group: Status: Elite Member
  • Posts: 7,000
  • Joined: 31-December 11
  • Gender:Male
  • Country:

Posted 23 April 2020 - 12:01 AM

Here is mine; I used your settings, but nothing changed.
Attached File  OpenRailsLog.txt (17.44K)
Number of downloads: 244

Attached Image: cabshift.jpg

#22 User is offline   cjakeman 

  • Vice President
  • PipPipPipPipPipPipPipPip
  • Group: ET Admin
  • Posts: 2,868
  • Joined: 03-May 11
  • Gender:Male
  • Location:Peterborough, UK
  • Simulator:Open Rails
  • Country:

Posted 23 April 2020 - 10:24 AM

View PostCsantucci, on 15 April 2020 - 11:58 PM, said:

Some points:
1) I'd suggest that the selection between letterboxing and usual view, instead of being made through a menu option, be done with a runtime toggle command. Ctrl-1 could be a possible candidate key for that.


With the advent of Ctrl-1, I think it's time the "% cab 2D stretch" control (below) was removed. If we do that, then we have a simple choice between the new black bars and the old scroll up and down.

What we don't need is the even older "100% stretch" which distorts the image and is all we had before the scroll up and down arrived.

Attached Image: 2020-04-23 19_14_54-Options.jpg


Is anyone keen to keep the "stretch" option?

#23 User is offline   YoRyan 

  • Conductor
  • Group: Status: Active Member
  • Posts: 391
  • Joined: 19-February 20
  • Gender:Male
  • Location:California, United States
  • Simulator:Open Rails/unstable
  • Country:

Posted 23 April 2020 - 11:47 AM

I would be in favor of removal. The stretching control, a numerical percentage, is rather baffling to the uninitiated user (i.e., me!).

Chris, any chance you could build with the letterboxing patch and see if you're seeing the same issue Csantucci is?

#24 User is offline   Csantucci 

  • Member, Board of Directors
  • Group: Status: Elite Member
  • Posts: 7,000
  • Joined: 31-December 11
  • Gender:Male
  • Country:

Posted 23 April 2020 - 12:24 PM

I'm also in favour of a removal. I don't like oval needle tachos, I like round needle tachos.

#25 User is offline   markus_GE 

  • Executive Vice President
  • PipPipPipPipPipPipPipPipPip
  • Group: ET Admin
  • Posts: 4,862
  • Joined: 07-February 13
  • Gender:Male
  • Location:Leoben, Styria, Austria, Europe
  • Simulator:ORTS / MSTS
  • Country:

Posted 23 April 2020 - 12:48 PM

View PostCsantucci, on 23 April 2020 - 12:24 PM, said:

I'm also in favour of a removal. I don't like oval needle tachos, I like round needle tachos.


Well put, Carlo! http://www.elvastower.com/forums/public/style_emoticons/default/good2.gif


I've been fiddling with those percentages over and over, every time I fired up ORTS in all those years since I got to know it, and I could never find a suitable optimum between scrolling and distorting the image...
For that reason, I really like the letterboxing approach and am looking forward to trying it myself. http://www.elvastower.com/forums/public/style_emoticons/default/clapping.gif

With that said, IMHO, just go ahead and remove the scaling thingy. http://www.elvastower.com/forums/public/style_emoticons/default/whistling.gif

Cheers, Markus

#26 User is offline   YoRyan 

  • Conductor
  • Group: Status: Active Member
  • Posts: 391
  • Joined: 19-February 20
  • Gender:Male
  • Location:California, United States
  • Simulator:Open Rails/unstable
  • Country:

Posted 23 April 2020 - 05:39 PM

I found the bug! Turning on superelevation selected a code path I neglected to update for letterboxing. I have refactored the cab drawing code and pushed a fix. (Csantucci, here's your PR. Fingers crossed.) :)

#27 User is offline   Csantucci 

  • Member, Board of Directors
  • Group: Status: Elite Member
  • Posts: 7,000
  • Joined: 31-December 11
  • Gender:Male
  • Country:

Posted 23 April 2020 - 11:19 PM

That seems to be OK now, thanks! Well, it was difficult to think at the superelevation as the cause of the issue.
PR merged.

#28 User is offline   Csantucci 

  • Member, Board of Directors
  • Group: Status: Elite Member
  • Posts: 7,000
  • Joined: 31-December 11
  • Gender:Male
  • Country:

Posted 24 April 2020 - 12:11 PM

So, YoRyan, in the framework of this feature you could remove the cab2D stretch option and the related code!

#29 User is offline   YoRyan 

  • Conductor
  • Group: Status: Active Member
  • Posts: 391
  • Joined: 19-February 20
  • Gender:Male
  • Location:California, United States
  • Simulator:Open Rails/unstable
  • Country:

Posted 24 April 2020 - 12:39 PM

I'm happy to do the work, but I have some logistical questions for the developer team first. :)

  • Do we need a new Trello card for getting rid of stretching?
  • Should that be a new PR, or can I tack it onto my existing one?
  • And which branch should these changes target, "master" or "unstable" (Monogame)?

#30 User is offline   hugoakio 

  • Hostler
  • PipPip
  • Group: Status: Fired
  • Posts: 51
  • Joined: 28-February 19
  • Gender:Male
  • Simulator:Open rails
  • Country:

Posted 24 April 2020 - 09:24 PM

View PostCsantucci, on 23 April 2020 - 12:24 PM, said:

I'm also in favour of a removal. I don't like oval needle tachos, I like round needle tachos.


Please, don't remove the cab strech!! My cabs are all configured to 40% strech. Actually many cabs are better with some strech, it's usual to many players. Consider keeping this option, please.
  • 4 Pages +
  • 1
  • 2
  • 3
  • 4
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users