[Icik]

Carlo, can I see the syntax somewhere? How will they be used?

[Csantucci]

Icik,
sorry, but I don't understand your question well. The syntax of what? For the script a stroke of the above key combinations will be the same as the mouse click on the ORTS_TCS1 or ORTS_TCS2 cab control.

[Icik]

How do I handle to turn TCS on / off with a keyboard shortcut? Is there a function for this?

[Csantucci]

This must be coded within the script itself. The TCS script starts always, but loops doing practically nothing until the starting keystrokes are pressed.

[Csantucci]

Csantucci, on 28 April 2020 - 12:52 PM, said:

As requested, two keyboard commands have been added in the TCS extensions; they are triggered by Ctrl+, and Ctrl+. . They are linked to the generic TCS controls ORTS_TCS1 and ORTS_TCS2. The commands are generic, and may be have any use within the TCS script. They might be used to start and stop the on-board Train Control System, but also for other functions.

This is now implemented in OR NewYear MG rev.60 and in the latest official Unstable release, where also all other TCS extensions are now available.

[Icik]

Carlo, I don't know how or what to test in the script to get true / false when I press Ctrl + or Ctrl + ..
Please, give me an advice.

[Csantucci]

Hi Icik,
you can download here http://www.interazio...ev8.0_provv.zip a new temporary release of the script for the Italian TCS, where I have implemented the check for key combinations Ctrl,(comma) to switch on the on board TCS and Ctrl.(period) to switch it off.
I also suggest you to update tomorrow morning the Testing version of OR. There should be an update in the OR manual, where YoRyan has written the basics of OR scripting.

The SCMT source is quite complicated. Here some hint about the points where the checks are performed. When one of the two key combinations are pressed and when they are released, method

       public override void HandleEvent(TCSEvent evt, string message)

at line 1883 of the script is called, and in particular lines from 1908 and further on are activated.
Key combination Ctrl,(comma) or Ctrl.(period) start HandleEvent; evt can have the two values TCSEvent.GenericTCSButtonPressed (when you start pressing the keys) and GenericTCSButtonReleased when you release them; message can be in our case "0" (string) for Ctrl,(comma) and "1" for Ctrl.(period). Within HandleEvent they are converted to integers and then to CommandEvent enums respectively as TCSCommandEvent.Accendi (switch on) and TCSCommandEvent.Spegni (switch off) and become indices for TCSButtonPressed[(int)commandEvent] and TCSButtonReleased[(int)commandEvent].
The relevant elements of TCSButtonPressed are then read within the update loop in UpdateSSBState() (line 1024). That method should be clear.

[YoRyan]

I'm working on some American TCS scripts, and I'm missing the ability to read the current positions of the throttle and brake handles. For example, when you get a penalty application on an American locomotive, you have to move the brake handle to Supression for 10 seconds before the TCS system will release the brakes.

Any chance of incorporating such a function into your changes?

[Icik]

Thank you so much Carlo! This is very helpful.

[Csantucci]

YoRyan, on 01 May 2020 - 12:38 PM, said:

I'm working on some American TCS scripts, and I'm missing the ability to read the current positions of the throttle and brake handles. For example, when you get a penalty application on an American locomotive, you have to move the brake handle to Supression for 10 seconds before the TCS system will release the brakes.

Any chance of incorporating such a function into your changes?

Hi Ryan,
I'm happy you're working on that.
With this hook that I added some days ago

Script.Locomotive = () => Locomotive;

you have access to the whole Simulator environment (locomotives, trains, signals and so on), e.g. in the script you can refer to

Locomotive().LocalThrottlePercent

provided you have inserted the required using lines at beginning of the script.

[YoRyan]

Thanks! Will take a look.

[Icik]

Hi Carlo, can you please extend the script to store certain variables? Sometimes you need to save the game and continue some other time. With this, the state of some variables must be saved so that the script works well even after loading the saved game.

[YoRyan]

One way to accomplish this might be to serialize the TrainControlSystem class itself and add it to the save. Then, when loading the save, deserialize the class. This would be completely transparent to the script and preserve all the state, but the "[Serializable]" decorator would have to be added to all scripts.

[Csantucci]

I have found a picklock to implement the save/restore feature without breaching backward compatibility with older scripts. It is available in OR NewYear MG 60.3.
Here an example on how to save and restore some variables within the script.

        public override void HandleEvent(TCSEvent evt, string message)
        {
            if (message == String.Empty)
            {
                switch (evt)
                {
                    ......
                    case TCSEvent.Save:
                        SaveInt32((int)SSBState);
                        SaveInt32((int)SCMTState);
                        SaveInt32((int)RSCState);
                        SaveInt32((int)RSCCode);
                        SaveBoolean(RSCPresent);
                        SaveSingle(normalSignalDistanceM);
                        break;
                    case TCSEvent.Restore:
                        SSBState = (SSBSTATE)ReadInt32();
                        SCMTState = (SCMTSTATE)ReadInt32();
                        RSCState = (RSCSTATE)ReadInt32();
                        RSCCode = (RSCCODE)ReadInt32();
                        RSCPresent = ReadBoolean();
                        normalSignalDistanceM = ReadSingle();
                        break;
                }
            }
            else
            {
            .....
            }
         }

[Icik]

Great Carlo! Great solution! It works.
Thanks!

PS: I have a feeling that even scripts for the TS2020 can't do that yet. :)