[steamer_ctn]

Hi Carlo,

Csantucci, on 20 November 2017 - 09:50 AM, said:

Is there any feedback about the file I uploaded deriving it from Dennis' patch? As there was a good number of people reporting problems with OR vacuum braking, it would be nice if some of them would test the proposed solution and report the results.

I created a blueprint for some work on ejectors, and vacuum brakes some time ago. I started work on it, but sadly I have been distracted on other activities for a while.

I am hoping to get back to it in the near future.

If you feel that it is urgent to commit the change then that is fine, otherwise I can have a look at it when I restart on the blueprint. I haven't looked at the proposed change, so I cannot comment on its validity at this time.

Thanks

[Csantucci]

Hi Peter,
my role in this change is a low-level one: I only built OR using Dennis' patch, but it's not me that can decide whether the patch is satisfying or not. So I won't commit it before someone knowledgeable in vacuum braking will state that the patch is an improvement.

[steamer_ctn]

Hi Carlo,

Csantucci, on 20 November 2017 - 10:55 PM, said:

my role in this change is a low-level one: I only built OR using Dennis' patch, but it's not me that can decide whether the patch is satisfying or not. So I won't commit it before someone knowledgeable in vacuum braking will state that the patch is an improvement.

Ok, no problems.

[dennisat]

Csantucci, on 20 November 2017 - 10:55 PM, said:

Hi Peter,
my role in this change is a low-level one: I only built OR using Dennis' patch, but it's not me that can decide whether the patch is satisfying or not. So I won't commit it before someone knowledgeable in vacuum braking will state that the patch is an improvement.

There have only been 3 downloads of your dll so far, so not many people seem to be interested.

Dennis

[dforrest]

Unfortunately, I now have X3987 installed.

[Csantucci]

Here the patched orts.simulation.dll for x.3987

22/11/2017: file deleted because fix committed

[dforrest]

Csantucci, on 21 November 2017 - 05:30 AM, said:

Here the patched orts.simulation.dll for x.3987
Orts.Simulation.dll.zip

This appears to have improved the braking with no adverse effects.

[Csantucci]

Fix committed in x.3988.

[rickloader]

Hi Carlo. I`m afraid I`ve encountered problems with Timetable mode and vacuum brakes.
x3984, x3986 timetables working ok.
x3987, x3988 timetable in demo route "SCE" working - air brakes
timetable in my test route - vacuum brakes- working (a very small route & timetable 3 trains 1 station)
timetable in my own development route vacuum brakes - out of range exception on loading.
"out of range exception Index was outside the bounds of the array"
Attached log has a lot of errors relating to route station changes, and also the timetables update. But it does work under x3986 and not under x3987/8
This timetable has a static observer loco and about 20 AI trains and I feel more suitable for investigation. My main timetable is rather chaotic, and attempts to resolve route and timetable changes with about 200 trains!
In activity mode I do feel the revised code in x3988 gives a vac brake improvement.
Many thanks for your work on vac brakes, and apologies if this problem is unrelated, rick
edit: reattached lost log. please note I only use steam locos - maybe changes to steam code are a factor?

Attached File(s)

•  OpenRailsLog 3988.txt (75.64K)
  Number of downloads: 180

[steamer_ctn]

rickloader, on 22 November 2017 - 08:01 AM, said:

I`m afraid I`ve encountered problems with Timetable mode and vacuum brakes.

This appears to be a problem I introduced in #3987.

Hopefully it has been corrected in #3989

Please confirm all ok again.