Elvas Tower: Bug in brake initialization with moving train - Elvas Tower

Jump to content

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Bug in brake initialization with moving train Rate Topic: -----

#1 User is offline   Csantucci 

  • Member, Board of Directors
  • Group: Status: Elite Member
  • Posts: 7,006
  • Joined: 31-December 11
  • Gender:Male
  • Country:

Posted 13 March 2015 - 09:53 AM

Something has been changed in brake initialization with moving train, introducing - in my opinion - a bug: EmergResPressurePSI (the pressure of the emergency reservoir) is set to 0 at activity start for all trainsets (try e.g. the standard activity Auto Train with set-out, for the Marias Pass route). This is wrong, and moreover has the effect that if you brake and release, the emergency reservoir pressure of all trainsets slowly begins to increase, leading to a very, very long time for full brake release.

#2 User is offline   gpz 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,772
  • Joined: 27-October 12
  • Gender:Male
  • Location:Budapest
  • Simulator:OpenRails
  • Country:

Posted 13 March 2015 - 10:43 AM

Indeed that is a bug. :clapping: Emergency reservoir pressure must always be maintained, even if no real equipment is present. In this case it represents a reference pressure. I will correct it.
"if ((Car as MSTSWagon).EmergencyReservoirPresent || maxPressurePSI != 0)" in Initialize must be simplified, to check only if maxPressurePSI > 0.

#3 User is offline   Csantucci 

  • Member, Board of Directors
  • Group: Status: Elite Member
  • Posts: 7,006
  • Joined: 31-December 11
  • Gender:Male
  • Country:

Posted 13 March 2015 - 12:27 PM

Hi Peter,
the emergency reservoir pressure is 0 not because it is not present, but because in AirSinglePipe.cs InitializeMoving calls Initialize by setting maxPressurePSI = 0, and therefore the test on maxPressurePSI you mention in your post does not apply and therefore EmergResPressurePSI remains at 0.

#4 User is offline   gpz 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,772
  • Joined: 27-October 12
  • Gender:Male
  • Location:Budapest
  • Simulator:OpenRails
  • Country:

Posted 13 March 2015 - 02:11 PM

Yes, I mentioned the same code. When I will modify it to check only maxPressurePSI > 0, that will result that the existing EmergResPressurePSI will not be overwritten with 0.

#5 User is offline   gpz 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,772
  • Joined: 27-October 12
  • Gender:Male
  • Location:Budapest
  • Simulator:OpenRails
  • Country:

Posted 14 March 2015 - 08:45 AM

Fixed in r2922.

#6 User is offline   Csantucci 

  • Member, Board of Directors
  • Group: Status: Elite Member
  • Posts: 7,006
  • Joined: 31-December 11
  • Gender:Male
  • Country:

Posted 14 March 2015 - 09:29 AM

Thanks Peter, it's OK now.

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users