Elvas Tower: Two small enhancements to smoke and steam - Elvas Tower

Jump to content

  • 3 Pages +
  • 1
  • 2
  • 3
  • You cannot start a new topic
  • You cannot reply to this topic

Two small enhancements to smoke and steam Wind effect and fog effect Rate Topic: -----

#11 User is offline   BB25187 

  • Fireman
  • Group: Status: Active Member
  • Posts: 138
  • Joined: 09-December 12
  • Gender:Male
  • Simulator:OpenRails MSTS
  • Country:

Posted 26 July 2014 - 08:05 AM

All,

Sorry I didn't connect to the forum during the past few days. In the mean time I fixed the points raised by gpz:
- Regarding the instance of the Random class, this was actually a mistake: it was not even used in my patch - I thus simply removed it). I attach the corresponding version of the patch.
- I also removed most of the comments
I will now try the patch modified by gpz and let you know my feeling.

Regards

Attached File(s)



#12 User is offline   BB25187 

  • Fireman
  • Group: Status: Active Member
  • Posts: 138
  • Joined: 09-December 12
  • Gender:Male
  • Simulator:OpenRails MSTS
  • Country:

Posted 26 July 2014 - 08:29 AM

Peter,

I applied your patch on top of mine, using a revision #2360. The smoke is OK, but the movements of the skydome look now erratic. The link below points to a video which shows this bizarre effect:

http://www.dailymoti...-perkins_travel

Regards

#13 User is offline   gpz 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,772
  • Joined: 27-October 12
  • Gender:Male
  • Location:Budapest
  • Simulator:OpenRails
  • Country:

Posted 28 July 2014 - 11:49 AM

Yes, looks like the sky wind code uses the total time as an input for a constant wind.
I have committed your patch as r2366, smoke fading in the fog looks really nice!

#14 User is offline   ATSF3751 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,085
  • Joined: 15-July 08
  • Gender:Male
  • Location:Wayzata, MN
  • Simulator:Open Rails
  • Country:

Posted 28 July 2014 - 08:06 PM

Im really liking the new improvements to the smoke and steam to steam locomotives and diesels. It looks really real and a lot more realistic.

Thanks

Brandon

#15 User is offline   captain_bazza 

  • Chairman, Board of Directors
  • PipPipPipPipPipPipPipPipPipPipPip
  • Group: ET Admin
  • Posts: 13,927
  • Joined: 21-February 06
  • Gender:Male
  • Location:Way, way, way, South
  • Simulator:MSTS & OR
  • Country:

Posted 28 July 2014 - 09:37 PM

If you will pardon the pun, as an interested modeller, these smoke and steam effects improvements are going in the right direction.

Thank you,
Bazza.

#16 User is offline   ATW 

  • Engineer
  • Group: Status: Contributing Member
  • Posts: 640
  • Joined: 07-January 13
  • Gender:Male
  • Simulator:MSTS Open Rails
  • Country:

Posted 29 July 2014 - 02:26 PM

The new smoke wind affect is amazing!!! Great Job :pleasantry:

Is it possible for the future for tunnels to have wind direction effects?

#17 User is offline   ATSF3751 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,085
  • Joined: 15-July 08
  • Gender:Male
  • Location:Wayzata, MN
  • Simulator:Open Rails
  • Country:

Posted 29 July 2014 - 06:25 PM

One thing I do not like is how the smoke comes out in little balls of smoke in the beginning and there are 2 of them. Just my opinion!

Brandon

#18 User is offline   gpz 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,772
  • Joined: 27-October 12
  • Gender:Male
  • Location:Budapest
  • Simulator:OpenRails
  • Country:

Posted 30 July 2014 - 12:10 AM

View PostATSF3751, on 29 July 2014 - 06:25 PM, said:

One thing I do not like is how the smoke comes out in little balls of smoke in the beginning and there are 2 of them. Just my opinion!

Is it after the recent changes, or it was there originally? Which locomotive have you seen this at?

#19 User is offline   copperpen 

  • Executive Vice President
  • Group: Status: Elite Member
  • Posts: 3,144
  • Joined: 08-August 05
  • Gender:Male
  • Simulator:MSTS & OR
  • Country:

Posted 30 July 2014 - 01:53 AM

The two streams of smoke have been present from the beginning of the new particle emissions code, but is much more visible if smaller orifice settings are used. The picture shown is using X 2369 and there are two smoke emission streams. This happens with any steam engine, and I have seen it on some diesels.

Attached thumbnail(s)

  • Attached Image: Clipboard01.jpg


#20 User is offline   gpz 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,772
  • Joined: 27-October 12
  • Gender:Male
  • Location:Budapest
  • Simulator:OpenRails
  • Country:

Posted 30 July 2014 - 02:26 AM

There is a code piece in MSTSSteamLocomotiveViewer.PrepareFrame function, where a "pulse" variable is being switched to either 0.25 or 1. This variable alters the steam output volume eventually, which the output speed depends on. I assume this could be a candidate for the reason. But this is rdamurphy's code, he could debug it.

  • 3 Pages +
  • 1
  • 2
  • 3
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users