[James Ross]

Laci1959, on 02 October 2021 - 03:18 AM, said:

REINFORCED. Working perfectly.

:sign_thanks:

[steamer_ctn]

PR #507 has been committed to fix a bug introduced which stopped the independent brake from reducing the Main Reservoir - see here (post #61) for the original identification.

This will effect all users and is only a small code change which should have minimal impact.

[Serana]

PR #512 fixes a problem during hill start when dynamic brake blending is enabled.

Dynamic brake blending requests dynamic brake even if the train is at standstill. It blocks throttle till pneumatic brake is released and, during a hill start, the train rolls back.

With the fix, the locomotive will no longer try to apply dynamic brake until the dynamic brake minimum speed is reached.

[James Ross]

steamer_ctn, on 02 October 2021 - 02:14 PM, said:

PR #507 has been committed to fix a bug introduced which stopped the independent brake from reducing the Main Reservoir - see here (post #61) for the original identification.

This will effect all users and is only a small code change which should have minimal impact.

Thanks, approved and merged into "release/1.4"!

Serana, on 02 October 2021 - 10:22 PM, said:

PR #512 fixes a problem during hill start when dynamic brake blending is enabled.

Dynamic brake blending requests dynamic brake even if the train is at standstill. It blocks throttle till pneumatic brake is released and, during a hill start, the train rolls back.

With the fix, the locomotive will no longer try to apply dynamic brake until the dynamic brake minimum speed is reached.

Are locomotives with dynamic brake blending common? Are hill starts common in those locomotives? Did this work correctly in 1.3.1?

The information we specifically need here is about how badly it would affect users if we didn't fix it in 1.4 and they had to wait for 1.4.1 or 1.5. We are at the point where we really only want very serious fixes (and all manual/translation updates), otherwise we will never actually make it to 1.4. :)

[Weter]

:) too
WRT translation, it covers almost all strings except Imperial UOM,s that are not used, so I don't see adequate analogs now.
But, what makes trouble for me-is risqué that new build can work unproperly with localized *.dlls but I still not understood the reason.

[pschlik]

James Ross, on 03 October 2021 - 01:35 AM, said:

Are locomotives with dynamic brake blending common? Are hill starts common in those locomotives? Did this work correctly in 1.3.1?

The information we specifically need here is about how badly it would affect users if we didn't fix it in 1.4 and they had to wait for 1.4.1 or 1.5. We are at the point where we really only want very serious fixes (and all manual/translation updates), otherwise we will never actually make it to 1.4. :)

Well from my perspective, basically every American passenger locomotive has brake blending and the whole throttle locking thing is a real pain, especially when trying to do a hill start (in real life, the throttle is not locked at all, ever, during blended braking). Anything which makes blended braking more realistic would be nice, but for now, there are workarounds and I figure most people are well accustomed to the (completely unrealistic) behavior of blended braking as-is.

Sounds like a handy feature, but not an "oh no I would DIE if this isn't fixed" feature.

[Weter]

Quote

basically every American passenger locomotive has brake blending and the whole throttle locking thing is a real pain, especially when trying to do a hill start (in real life, the throttle is not locked at All

Siemens locomotives too, btw...

[James Ross]

Serana, on 02 October 2021 - 10:22 PM, said:

PR #512 fixes a problem during hill start when dynamic brake blending is enabled.

Dynamic brake blending requests dynamic brake even if the train is at standstill. It blocks throttle till pneumatic brake is released and, during a hill start, the train rolls back.

With the fix, the locomotive will no longer try to apply dynamic brake until the dynamic brake minimum speed is reached.

Unless we hear back that this is going to be a huge issue for 1.4 users, we won't be taking it. You are welcome to re-target the fix at the "master" branch for inclusion in Testing Version.

[James Ross]

New version: 1.4-rc6

Changes:

• Merge pull request #507 from peternewell/brake-fix#1
  
• Merge pull request #509 from twpol/feature/particle-colour
  
• Merge pull request #505 from peternewell/air-compressor#1
  
• Merge pull request #498 from Sharpe49/power-supply-fix-cabview-controls
  
• Merge pull request #502 from peternewell/air-compressor#1

As we have almost reached four weeks of preparing, ORMT have agreed that only the most serious of issues (plus manual/translations) will be accepted for 1.4 now. We hope no such issues are found in the next two weeks!

[Serana]

James Ross, on 04 October 2021 - 09:29 AM, said:

Unless we hear back that this is going to be a huge issue for 1.4 users, we won't be taking it. You are welcome to re-target the fix at the "master" branch for inclusion in Testing Version.

I tested on 1.3.1, the problem is already happening.

[James Ross]

Serana, on 04 October 2021 - 10:11 AM, said:

I tested on 1.3.1, the problem is already happening.

Thanks, that confirms that won't take this in 1.4, but please do edit the PR to point at "master" so we can get the fix in for the next Stable and Testing versions.

[Serana]

Done !

[superheatedsteam]

steamer_ctn, on 02 October 2021 - 02:14 PM, said:

PR #507 has been committed to fix a bug introduced which stopped the independent brake from reducing the Main Reservoir - see here (post #61) for the original identification.

This will effect all users and is only a small code change which should have minimal impact.

I have tested the independent brake application not consuming main reservoir pressure problem in 1.4-rc6 and confirming that this issue is now resolved.

Many thanks Peter and the rest of the development team for all your time and effort.

Cheers,

Marek.

[steamer_ctn]

superheatedsteam, on 05 October 2021 - 03:39 AM, said:

I have tested the independent brake application not consuming main reservoir pressure problem in 1.4-rc6 and confirming that this issue is now resolved.

Many thanks Peter and the rest of the development team for all your time and effort.

Thanks for the confirmation.

[nounours1952]

Good evening,

I have a problem with the script in the appendix. The brakes do not work with version 1.4.

Kindly
Pascal

Attached File(s)

•  PBL2BrakeController.7z (2.18K)
  Number of downloads: 601