[engmod]

 nounours1952, on 13 September 2021 - 01:37 AM, said:

This "monogame" version does not start if "avast" antivirus is enabled.

That is an Avast problem, not an OR problem.

[cjakeman]

 Csantucci, on 11 September 2021 - 11:28 AM, said:

OK, I've uploaded the three PRs. PR #477 must be merged as first.

And I've merged them, PR #477 first.

[James Ross]

 nounours1952, on 13 September 2021 - 01:37 AM, said:

The update to the old stable version seems to be an oversight.

https://zupimages.net/up/21/37/anwa.jpg

It's a known bug, unrelated to 1.4. You likely opened the 1.3.1 Stable Version earlier in the day - because the updater caches the latest information for the whole day, switching between versions on the same day often results in seemingly odd updates being available.

[James Ross]

New version: 1.4-rc3

Changes:

• Merge pull request #479 from Csantucci/3Dcabs-allow-bars-ranging-from-negative-to-positive-values
  
• Merge pull request #478 from Csantucci/3dcab-fix-for-alert-colour-not-displayed
  
• Merge pull request #477 from Csantucci/3D-cab-solid-bar-and-digital-fix
  
• Merge pull request #476 from twpol/feature/update-from-anywhere

[Serana]

Hi,

I am proposing another fix (with some refactoring) for the release candidate (https://github.com/o...nrails/pull/482).
The problem is linked to what was said in this message: http://www.elvastowe...post__p__275315
This problem was then forwarded to me by Carlo by PM.


Basically, in the power supply package, there was an error in the way that the Control Player Engine key was handled.
Basically, it started all of the engines of the train whereas it should only start the first engine of the player locomotive.
The other engines must start only when the Control Helper Engine key is used.

This problem would have been fixed weirdly if the refactoring was not made because a part of the code managing the diesel engine start or stop commands was not using the new power supply classes.
And the way the power supply classes are designed implies that it's the power supply class that should decide what to do when a key related to power supply is pressed.
So the refactoring consist in moving the old code in the power supply classes.

[engmod]

Gents,

Running FJ&G route ( a Paul Charland switching route ).

I was running around a car and when I switched the point at the end to run around, the car disappeared. Nothing in the log.
When you go back to where the car was, it can be seen on the track, but connecting to it does not show the car number.

This is repeatable from a save.

I will move to RC3 and start the activity afresh after a reboot and see what happens.

[engmod]

False alarm.

2.1% grade.

The car rolled away, first time I have ever had a car roll away on a grade!!

[Csantucci]

With PR #486 I am adding the clamping for digitals in 3D cabs, using the identical code line used for 2D cabs. That check was missing as evidenced here http://www.elvastowe...post__p__276041 . Due to the limited intervention, I am proposing this fix to be inserted in stable release 1.4.

[James Ross]

 Serana, on 15 September 2021 - 11:46 AM, said:

This problem would have been fixed weirdly if the refactoring was not made because a part of the code managing the diesel engine start or stop commands was not using the new power supply classes.
And the way the power supply classes are designed implies that it's the power supply class that should decide what to do when a key related to power supply is pressed.
So the refactoring consist in moving the old code in the power supply classes.

I have approved and merged this change - thanks!

[James Ross]

 Csantucci, on 16 September 2021 - 07:25 AM, said:

With PR #486 I am adding the clamping for digitals in 3D cabs, using the identical code line used for 2D cabs. That check was missing as evidenced here http://www.elvastowe...post__p__276041 . Due to the limited intervention, I am proposing this fix to be inserted in stable release 1.4.

Approved and merged - thanks!