Elvas Tower: ETS Appears to Cause NaN Errors on Diesel Shutdown - Elvas Tower

Jump to content

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

ETS Appears to Cause NaN Errors on Diesel Shutdown Rate Topic: -----

#1 User is offline   steamer_ctn 

  • Open Rails Developer
  • Group: Status: Elite Member
  • Posts: 1,889
  • Joined: 24-June 11
  • Gender:Male
  • Country:

Posted 08 August 2021 - 10:59 PM

With the introduction of ETS a couple of bugs seem to have been introduced to DieselEngines.cs. When the diesel engine is shut down (using Shft+Y) the DieselOutputPower and the Load% both go to NaN values.

This appears to being caused by NumOfActiveEngines going to zero. This parameter is then used to calculate the above two values, and is creating NaN values because of the divide by zero error. Prior version of code don't appear to use this parameter in the calculations.

Could the relevant developer please look at this and a couple of other issues (described elsewhere) that appear to be related to ETS?

Thanks

#2 User is offline   Serana 

  • Conductor
  • Group: Status: Contributing Member
  • Posts: 489
  • Joined: 21-February 13
  • Gender:Male
  • Location:St Cyr l'Ecole (France)
  • Simulator:Open Rails
  • Country:

Posted 16 August 2021 - 05:12 AM

I will take a look at that.

#3 User is offline   Serana 

  • Conductor
  • Group: Status: Contributing Member
  • Posts: 489
  • Joined: 21-February 13
  • Gender:Male
  • Location:St Cyr l'Ecole (France)
  • Simulator:Open Rails
  • Country:

Posted 16 August 2021 - 05:35 PM

I just sent some fixes on Github (https://github.com/o...nrails/pull/454).

It should work properly now.

#4 User is offline   steamer_ctn 

  • Open Rails Developer
  • Group: Status: Elite Member
  • Posts: 1,889
  • Joined: 24-June 11
  • Gender:Male
  • Country:

Posted 17 August 2021 - 12:45 PM

 Serana, on 16 August 2021 - 05:35 PM, said:

It should work properly now.

Thanks for that it appears to work correctly now.
Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users