Elvas Tower: Center Camera on Center of Car Please? - Elvas Tower

Jump to content

  • 2 Pages +
  • 1
  • 2
  • You cannot start a new topic
  • You cannot reply to this topic

Center Camera on Center of Car Please? Rate Topic: -----

#1 User is offline   SD45T-2 

  • Foreman Of Engines
  • Group: Status: Contributing Member
  • Posts: 764
  • Joined: 28-November 08
  • Gender:Male
  • Location:Louisiana
  • Simulator:OR, Trainz, and Misc. Sims.
  • Country:

Posted 27 August 2020 - 10:44 AM

ORTS Developers,

Why does the 2 and 3 views center on the front and rear of a car, instead of in the center like the 4 camera does?

This is a poor setup for someone who is used to having the Camera centered on the centered of the car, and is a common complaint with OR.

Can this please be fixed, or at least tell me where the camera code is so I can fix it myself?

#2 User is offline   Weter 

  • Member, Board of Directors
  • PipPipPipPipPipPipPipPipPipPip
  • Group: ET Admin
  • Posts: 6,926
  • Joined: 01-June 20
  • Gender:Not Telling
  • Simulator:ORTS
  • Country:

Posted 29 August 2020 - 01:54 AM

Maybe Shift+2(3) can be assigned to toggle camera's focus face to/center?
Centering at face-ends of front/end car is sometimes useful. And You can rotate camera's axle, holding Alt or Mouse-right buttons pressed.

#3 User is offline   SD45T-2 

  • Foreman Of Engines
  • Group: Status: Contributing Member
  • Posts: 764
  • Joined: 28-November 08
  • Gender:Male
  • Location:Louisiana
  • Simulator:OR, Trainz, and Misc. Sims.
  • Country:

Posted 30 August 2020 - 05:43 PM

View PostWeter, on 29 August 2020 - 01:54 AM, said:

Centering at face-ends of front/end car is sometimes useful. And You can rotate camera's axle, holding Alt or Mouce-right buttons pressed.


First, Shift+2(3), does not work.

You can maipulate the camera, but that's a pain. It's not something people want to do.

And while it's useful sometimes, there's a lot to be said for conventions. Every other Train-Sim has the external pacing view camera centered on the center of a car/engine, why should OR be different? I know OR is a unique thing altogther, but having the 2 and 3 cameras centered on the front and end of the car seems very arbitrary, with no rhyme or reason why OR is different in this aspect.

If we re-center the 2 and 3 cameras on the center of the car/engine, that will make people more comfortable using Open Rails, because it's how every other train-sim acts.

#4 User is offline   Weter 

  • Member, Board of Directors
  • PipPipPipPipPipPipPipPipPipPip
  • Group: ET Admin
  • Posts: 6,926
  • Joined: 01-June 20
  • Gender:Not Telling
  • Simulator:ORTS
  • Country:

Posted 31 August 2020 - 07:43 AM

Quote

First, Shift+2(3), does not work.

Sorry, I wasn't clear: the possible key combination was mentioned (which is not implemented now)
And... of cource, I didn't want to say, that Your proposal is not good.

#5 User is offline   vince 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,314
  • Joined: 18-June 14
  • Gender:Male
  • Location:West of the Contental Divide
  • Simulator:ORTS_Running MSTS_Editing
  • Country:

Posted 31 August 2020 - 02:54 PM

Leave as is.

vince


#6 User is offline   SD45T-2 

  • Foreman Of Engines
  • Group: Status: Contributing Member
  • Posts: 764
  • Joined: 28-November 08
  • Gender:Male
  • Location:Louisiana
  • Simulator:OR, Trainz, and Misc. Sims.
  • Country:

Posted 31 August 2020 - 05:48 PM

Vince, could you please explain why should we leave it as it is?

As I mentioned, this decision feels arbitrary, with no rhyme or reason as to why it's this way.

ORTS is the only program that doesn't have pacing views at the center of a car/locomotive.

Trainz has it centered on the center of a car/locomotive.
MSTS had it centered on the center of a car/locomotive.
Railworks has it centered on the center of a car/locomotive.
TSW has it centered on the center of a car/locomotive.
Many vehicle sims have it on the center of the vehicle.

And other sims that don't operate in a First Person view.

#7 User is offline   vince 

  • Superintendant
  • Group: Status: Elite Member
  • Posts: 1,314
  • Joined: 18-June 14
  • Gender:Male
  • Location:West of the Contental Divide
  • Simulator:ORTS_Running MSTS_Editing
  • Country:

Posted 31 August 2020 - 07:27 PM

View PostSD45T-2, on 31 August 2020 - 05:48 PM, said:

Vince, could you please explain why should we leave it as it is?

As I mentioned, this decision feels arbitrary, with no rhyme or reason as to why it's this way.

ORTS is the only program that doesn't have pacing views at the center of a car/locomotive.


The others got it wrong?

#8 User is offline   Genma Saotome 

  • Owner Emeritus and Admin
  • PipPipPipPipPipPipPipPipPipPipPipPipPip
  • Group: ET Admin
  • Posts: 15,350
  • Joined: 11-January 04
  • Gender:Male
  • Location:United States
  • Simulator:Open Rails
  • Country:

Posted 31 August 2020 - 07:27 PM

Of course it is arbitrary. That's because w/o a camfig file there can be only one solution and whomever coded it figured their idea was good enough. Unfortunately nobody wanted to bother coding up a camfig file to replace that.

If you search the Developers Ideas for the string "Camera Sets" you will find a proposal to bring the camfig into OR and make it a modern implementation, which is to say up to 10 camera positions for each set. That could mean 4 locomotive tracking cameras that are 2m above the group, another 4 that are 4m up, one way ahead looking back, one well behind (and say 5m high) looking forward. Copy that and specify end of train. That's 2 sets. Copy that and specify f4 type tracking. Get the idea? Anyway, Chris Jakeman started on that but set it aside. Perhaps he'll pick it up again.

#9 User is offline   YoRyan 

  • Conductor
  • Group: Status: Active Member
  • Posts: 391
  • Joined: 19-February 20
  • Gender:Male
  • Location:California, United States
  • Simulator:Open Rails/unstable
  • Country:

Posted 02 September 2020 - 06:19 PM

You can already adjust the pivot point with Shift-Alt-PgDown and Shift-Alt-PgUp keys; Carlo implemented them last year. (Side note: This satisfies this outstanding Trello card.)

But yes, defaulting to the end of the railcar is pretty silly. I can think of no rational reason to do this. So here's a patch to move it back to the center:

diff --git a/Source/RunActivity/Viewer3D/Cameras.cs b/Source/RunActivity/Viewer3D/Cameras.cs
index 8fa3e24ad..78a5987bc 100644
--- a/Source/RunActivity/Viewer3D/Cameras.cs
+++ b/Source/RunActivity/Viewer3D/Cameras.cs
@@ -1066,7 +1066,7 @@ protected override void OnActivate(bool sameCamera)
                 {
                     SetCameraCar(GetCameraCars().First());
                     browsedTraveller = new Traveller(attachedCar.Train.FrontTDBTraveller);
-                    ZDistanceM = 0;
+                    ZDistanceM = -attachedCar.CarLengthM / 2;
                     HighWagonOffsetLimit = 0;
                     LowWagonOffsetLimit = -attachedCar.CarLengthM;
                 }
@@ -1075,7 +1075,7 @@ protected override void OnActivate(bool sameCamera)
                     var trainCars = GetCameraCars();
                     SetCameraCar(trainCars.Last());
                     browsedTraveller = new Traveller(attachedCar.Train.RearTDBTraveller);
-                    ZDistanceM = -attachedCar.Train.Length + (trainCars.First().CarLengthM + trainCars.Last().CarLengthM) * 0.5f;
+                    ZDistanceM = -attachedCar.Train.Length + (trainCars.First().CarLengthM + trainCars.Last().CarLengthM) * 0.5f + attachedCar.CarLengthM / 2;
                     LowWagonOffsetLimit = -attachedCar.Train.Length + trainCars.First().CarLengthM * 0.5f;
                     HighWagonOffsetLimit = LowWagonOffsetLimit + attachedCar.CarLengthM;
                 }
@@ -1237,7 +1237,6 @@ public override void Update(ElapsedTime elapsedTime)
             }
             else if (attachedCar != null)
             {
-                attachedLocation.Z += attachedCar.CarLengthM / 2.0f * (Front ? 1 : -1);
                 LookedAtPosition = new WorldPosition(attachedCar.WorldPosition);
             }
             UpdateLocation(LookedAtPosition);



#10 User is offline   YoRyan 

  • Conductor
  • Group: Status: Active Member
  • Posts: 391
  • Joined: 19-February 20
  • Gender:Male
  • Location:California, United States
  • Simulator:Open Rails/unstable
  • Country:

Posted 03 September 2020 - 08:20 AM

I have filed a Trello card for this change. If management approves, I will file a PR.

  • 2 Pages +
  • 1
  • 2
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users