[Amtrak115]

I know these are just "Warnings" but hopefully I'll learn something about how OR and the signalling works if I delve into it a little....

Mode = activity
Route = ATSF Chillicothe Sub
Activity = AMTRAK #3 SW Chief-Sept-1995 (F:\ORTS\ATSF\ROUTES\atsfch\ACTIVITIES\AMTRAK #3 SW Chief-Sept-1995.act)
--------------------------------------------------------------------------------
Loading TRK TDB SIGCFG DAT ACT RDB CARSPAWN SIGSCR

Warning: sigscr-file line 1836 : Unknown parameter in statement : /*^ENABLED

Warning: sigscr-file line 1836 : Unknown function call : */BLOCK_STATE()
Details : System.ArgumentException: Requested value '*/BLOCK_STATE' was not found.
at System.Enum.EnumResult.SetFailure(ParseFailureKind failure, String failureMessageID, Object failureMessageFormatArgument)
at System.Enum.TryParseEnum(Type enumType, String value, Boolean ignoreCase, EnumResult& parseResult)
at System.Enum.Parse(Type enumType, String value, Boolean ignoreCase)
at Orts.Formats.Msts.SignalScripts.SCRScripts.process_FunctionCall(String FunctionStatement, IDictionary`2 LocalFloats, IList`1 ORSignalTypes, IList`1 ORNormalSubtypes, Int32 linenumber) in E:\Documents\Coding\Jenkins\jobs\Open Rails Testing\workspace\Source\Orts.Formats.Msts\SignalScripts.cs:line 1603

Warning: sigscr-file line 1907 : Unknown parameter in statement : /* ^ENABLED

Warning: sigscr-file line 1907 : Unknown function call : */BLOCK_STATE()
Details : System.ArgumentException: Requested value '*/BLOCK_STATE' was not found.
at System.Enum.EnumResult.SetFailure(ParseFailureKind failure, String failureMessageID, Object failureMessageFormatArgument)
at System.Enum.TryParseEnum(Type enumType, String value, Boolean ignoreCase, EnumResult& parseResult)
at System.Enum.Parse(Type enumType, String value, Boolean ignoreCase)
at Orts.Formats.Msts.SignalScripts.SCRScripts.process_FunctionCall(String FunctionStatement, IDictionary`2 LocalFloats, IList`1 ORSignalTypes, IList`1 ORNormalSubtypes, Int32 linenumber) in E:\Documents\Coding\Jenkins\jobs\Open Rails Testing\workspace\Source\Orts.Formats.Msts\SignalScripts.cs:line 1603

[Csantucci]

Please attach the zipped logfile and the zipped sigscr.dat file.

[Amtrak115]

As requested...

Attached File(s)

•  or-issue.zip (6.44K)
  Number of downloads: 244

[perpetualKid]

just looking at the log and the sigscr.dat in the mentioned lines (1836), I would guess the signal script parser has some hickup at these inline comments


if ( /*!enabled || */ // Not enabled/cleared to show natural state?
block_state() !=# BLOCK_CLEAR || // Block ahead not clear?


You may try to either delete them, or insert some line break before/after


if (
/*!enabled || */ // Not enabled/cleared to show natural state?
block_state() !=# BLOCK_CLEAR || // Block ahead not clear?


The signal script code is formally correct, but the script parser may not catch this correctly.

[Amtrak115]

perpetualKid, on 03 August 2020 - 01:43 PM, said:

just looking at the log and the sigscr.dat in the mentioned lines (1836), I would guess the signal script parser has some hickup at these inline comments


if ( /*!enabled || */ // Not enabled/cleared to show natural state?
block_state() !=# BLOCK_CLEAR || // Block ahead not clear?


You may try to either delete them, or insert some line break before/after


if (
/*!enabled || */ // Not enabled/cleared to show natural state?
block_state() !=# BLOCK_CLEAR || // Block ahead not clear?


The signal script code is formally correct, but the script parser may not catch this correctly.

Deleting the inline comment /*!enabled || */ or inserting a line break as shown above, cleared the warning messages from the log. BTW this was using "Open Rails X1.3.1-201-gbf7d2e6f4" testing release