[steamer_ctn]

Csantucci, on 13 October 2018 - 10:03 PM, said:

the engine part is not parsed and by consequence EngineType is left to steam, which is the default.

I suspected that this might be the case.

Csantucci, on 13 October 2018 - 10:03 PM, said:

I think that it would be safer to replace the if clause with the following one

        if (this is MSTSSteamLocomotive)

I am happy to do this, and will add it.

I will also change a few other similar occurrences. However there are other locations where EngineType is also used as a test (and can't be easily adapted), so since the ENG file will not be correctly parsed, other problems with performance will be created. In this instance as it appears to be a dummy cab file the performance issues may not have been noticeable even if it loaded successfully.

I am wondering whether we could create an error checking message to appear in the log to advise a user that there is a potential problem with the file. For example all ENG files should have at least one engine parameter parsed successfully. Perhaps the Type parameter could be used as the test. So say, if no Type parameter is defined for an ENG file then a warning message is added to the log.

Can you think of an easy or better way to do this?

Thanks

[engmod]

Ok,

6951 had an extra brace in the second section and was missing one in the first section.

Corrected, the activity has just crashed, I will include all the files.

Attached File(s)

•  4260_crash_after_6951_corrected.zip (13.54K)
  Number of downloads: 262

[Csantucci]

Hi Peter,
yes, having such a check could be a good idea. A further thing I had in mind is this: you see that WagonType has as default "Unknown". I'd insert also for EngineType an "Unknown" default value. So if after parsing of a wagon or engine file EngineType is at "Unknown" and WagonType is at "Engine", WagonType could be reverted to "Unknown". However I wouldn't dare to do this before 1.3, while the replacement suggested in my above post could be done now.

[steamer_ctn]

engmod, on 13 October 2018 - 10:45 PM, said:

Corrected, the activity has just crashed, I will include all the files.

Did the activity run for a longer period?

Does the consist run in Explorer mode?

[steamer_ctn]

Csantucci, on 13 October 2018 - 10:48 PM, said:

yes, having such a check could be a good idea.

Given the state of some ENG/WAG files, I think as many error checks as possible would be good to help people to identify problem files.

Csantucci, on 13 October 2018 - 10:48 PM, said:

WagonType could be reverted to "Unknown"

How would this then change OR operation?

Thanks

[engmod]

4261 crash is different.

Attached File(s)

•  OpenRailsLog.txt (22.26K)
  Number of downloads: 251

[Csantucci]

Hi Peter,
pls take note that in x.4261 you have changed also ContentManager.csproj. In fact this is a strange thing that occurs also to me. Since the last changes made by James in the Content Manager, everytime I build with Visual Studio, it modifies ContentManager.csproj.

[Csantucci]

engmod, on 13 October 2018 - 11:41 PM, said:

4261 crash is different.

Apparently here there is an AI train that has a locomotive with no notches.
The story seems to be this: You had the first crash. Peter found the problem in the .eng file. You corrected it and got the same crash again (see post #8). Then Peter corrected the code with x.4261 and you got another crash. The most likely case is that in the trainsets of this activity there is another trainset that has the same problem with the braces; less likely case is that the correction in the 6951 is not complete.

[steamer_ctn]

Hi Carlo,

Csantucci, on 13 October 2018 - 11:57 PM, said:

pls take note that in x.4261 you have changed also ContentManager.csproj. In fact this is a strange thing that occurs also to me. Since the last changes made by James in the Content Manager, everytime I build with Visual Studio, it modifies ContentManager.csproj.

I was getting the same issue with ContentManager.csproj changing for some reason.

With the last commit, I forgot to untick the box against it. I had already sent him a PM to correct the error that I made.

[engmod]

Csantucci, on 14 October 2018 - 12:03 AM, said:

Apparently here there is an AI train that has a locomotive with no notches. Are the trainsets (player train and AIs) in this activity only based on the trainsets that you have attached in post #8?

I will change all AI trains to full engines, and test again.