[engmod]

I am still getting pages of these:-



Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

Information: Sound Update return False

[dennisat]

This is a message inserted a long time ago when I was checking the operation of part of the sound process. In my testing, nothing ever seemed to drop into that section and I ran activities with up to 60 AI trains. From your experience however, it does seem that that section of code can get used. Could you post your OR log so that it can be checked to see if there is anything else going on.

It may be that the active part of that code block (currently commented out):

removals.Add(new KeyValuePair<object, SoundSourceBase>(sources.Key, sources.Value[i]));

needs to be reinstated.

Dennis

[engmod]

ok

Attached File(s)

•  OpenRailsLog.txt (24.34K)
  Number of downloads: 200

[dennisat]

This problem seems to be the same as in bug Bug 1572893. A fix was applied in X3590. However, there does seem to be cases where this has not been a complete solution and I think these occur on lower power PCs. This is almost certainly due to the Sound and Update processes running in separate threads and getting slightly out of step. I have a fairly high power PC which is probably why I don't see the problem. The message and the code change referred to above were inserted several years ago when I submitted various patches for a sound enhancement. Since there appears to be no reported associated problems with sound when these messages are issued, perhaps the message should be removed. I will take advice on this.

Dennis

[engmod]

Hi Dennis,

More on a different route.
I have a high powered machine as well, as you can see.

Attached File(s)

•  OpenRailsLog.txt (23.75K)
  Number of downloads: 270

[dennisat]

Hi,

I've taken advice about this message and it has set me thinking about how I might generate some instances of it myself. This should aid analysing the situation more thoroughly. I'll work on it as often as I can.

Dennis

[dennisat]

dennisat, on 08 January 2018 - 03:24 AM, said:

I've taken advice about this message and it has set me thinking about how I might generate some instances of it myself. This should aid analysing the situation more thoroughly. I'll work on it as often as I can.

I've succeeded in generating some of these messages by running OR at accelerated rates but they are not reliably repeatable. I have to run at something like 15x normal speed but even then I only get the messages about one in every 10 tests. If I run at even higher speeds then OR doesn't crash but I get other problems like shapes not loading and vanishing scenery and still none of the messages I'm looking for. I'm now going to resurrect my previous less powerful PC and get it running OR and see if I can get reliably repeatable data. My current PC is an i7 6700 Skylake 4 x 4Ghz overclocked to 4.5GHz and MSTS and OR on SSD.

Dennis

[hroch]

Hello,

I also receive these error messages, but only in activity mode. I do not have in Explore Route this message. I do not tested in timetable mode.

[engmod]

Hi Dennis,

I am getting these again.

A look through the source shows the string in both of the "SoundProcess.cs"

Is that the one generating these messages?

[dennisat]

engmod, on 20 March 2018 - 12:49 AM, said:

Hi Dennis,
I am getting these again.
A look through the source shows the string in both of the "SoundProcess.cs"
Is that the one generating these messages?

Yes, that's the one.

I've been away for 2 weeks recently and haven't caught up with my investigations. Two weeks skiing addles my brain these days.

I still haven't been able to reliably generate these messages myself. Before I went skiing, I was looking into the logic of trains.cs where the removal of sound sources from out of sight / removed trains is supposed to be initiated. The message from the sound process is an indication that the removal hasn't happened in trains.cs. I'm thinking that it's a timing issue between the sound / update / load threads and because my PC (and even my old PC) are relatively fast I'm practically never seeing the message. I think that the message is generated because the sound process has got in before the update / load processes have had their shot at removing the sound source. Since no-one has reported that they get unending streams of these messages, I mean literally thousands and thousands, the sound source must be being removed by the next cycle of the update / load processes.

I'm of the opinion that the message is redundant and could be removed.

Dennis