Elvas Tower: Restoring tilting feature - Elvas Tower

Jump to content

2 Pages
←
1
2

You cannot start a new topic
You cannot reply to this topic

Restoring tilting feature Rate Topic:

#11 James Ross

Open Rails Developer

Group: Status: Elite Member
Posts: 5,490
Joined: 30-June 10
Gender:Not Telling
Simulator:Open Rails
Country:

Posted 03 December 2016 - 02:26 AM

Csantucci, on 28 November 2016 - 10:05 AM, said:

I have opened this blueprint https://blueprints.l...tilting-feature and hope to get approval in order to restore this nice feature.

The idea of the feature is fine, but I am concerned about the implementation: it suffers from the same problem as the old super-elevation code in being non-deterministic. E.g. if you save the game and reload it, the tilting of a train may change. You can probably fix that by saving prevTilted.

I suggest we also fix those bad names, prevTilted and tz. :)

(It's hard to tell if you've changed anything in the vibrations code because the diff includes whitespace changes, but I am trusting you have not.)

#12 Csantucci

Member, Board of Directors

Group: Status: Elite Member
Posts: 6,999
Joined: 31-December 11
Gender:Male
Country:

Posted 03 December 2016 - 03:55 AM

The vibration code is untouched, I can reassure you :)
I used the original name of the variables; I have now changed them to the friendlier TiltingZRot and PrevTiltingZRot, and added the second one to the save/resume list (even if the filter is quite fast, so that the effect wasn't so bad).
Here the revised patch.