Elvas Tower: Coupler broken in TT mode - Elvas Tower

Jump to content

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Coupler broken in TT mode Rate Topic: -----

#1 User is offline   istvanek 

  • Hostler
  • Group: Status: Active Member
  • Posts: 74
  • Joined: 23-March 15
  • Gender:Male
  • Simulator:ORTS
  • Country:

Posted 03 November 2015 - 10:38 AM

Hello,

I've noticed that after x3291 there is no longer possible to run my timetable. I'm getting 'Num of coupler breaks: 1' error before the sim starts and then 'System.NullReferenceException' error.

The same train with the same timetable works fine with x3290.

'Break coupler' and 'curve speed dependent' options were off during tests.

Attaching logs from x3290 and x3295.

Is anything wrong with my trainset config or this is a bug?

Attached File(s)

  • Attached File  log.zip (7.26K)
    Number of downloads: 172

#2 User is offline   disc 

  • Foreman Of Engines
  • Group: Private - Open Rails Developer
  • Posts: 818
  • Joined: 07-October 12
  • Gender:Male
  • Simulator:OpenRails
  • Country:

Posted 03 November 2015 - 10:44 AM

Same here, my TT not works anymore, a coupler break and NullReferenceException

coupler breaks happen in activity mode too during the loading, but no nullreference.

Maybe it's caused by the changes in revision 3291

#3 User is offline   roeter 

  • Vice President
  • Group: Status: Elite Member
  • Posts: 2,426
  • Joined: 25-October 11
  • Gender:Male
  • Country:

Posted 03 November 2015 - 11:35 AM

Checking through the code, I have allready found one serious error.
A variable is used named "Simulator.CurveDurability". This is derived from the train's config durability in the method "InitializePlayerTrain", in Simulator.cs. But this method is only called in Activity mode, not in Timetable mode.
This means that, in timetable mode, the CurveDurability is always 0, as is this is used to calculate the max. curve speed by multiplying the safe curve speed with this factor, the maximum durability curve speed in timetable mode is always 0. So any train going through any curve will always exceed the durability speed.
I have not found it yet, but perhaps there is a similar error in some other variable used in these calculations.
Another serious issue is that the implementation of the breaking logic would be active only if the related settings are switched on. But I have found many calculations and checks which are non-conditional, so it seems at least part of the calculations AND RELATED WARNINGS (!) are not conditional at all. That was not what was agreed :thumbdown3: .

Regards,
Rob Roeterdink

#4 User is offline   steamer_ctn 

  • Open Rails Developer
  • Group: Status: Elite Member
  • Posts: 1,890
  • Joined: 24-June 11
  • Gender:Male
  • Country:

Posted 03 November 2015 - 08:09 PM

I have uploaded a small patch that hopefully eliminates the bug on starting TT mode.

Can you please confirm that TT mode is now working again?

Thanks

#5 User is offline   disc 

  • Foreman Of Engines
  • Group: Private - Open Rails Developer
  • Posts: 818
  • Joined: 07-October 12
  • Gender:Male
  • Simulator:OpenRails
  • Country:

Posted 04 November 2015 - 04:05 AM

TT is working now.

#6 User is offline   istvanek 

  • Hostler
  • Group: Status: Active Member
  • Posts: 74
  • Joined: 23-March 15
  • Gender:Male
  • Simulator:ORTS
  • Country:

Posted 04 November 2015 - 12:07 PM

I can confirm, TT is working. Thank you Peter.
Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users