[Genma Saotome]

With V2797 I'm seeing a lot of warning messages of "System.IndexOutOfRangeException: Index was outside the bounds of the array" followed by a failure to display a shape -- a shape that's been displaying since day 1. Many shapes actually.

I've no problem w/additional checks but I do object to failing to display stuff that's been displaying perfectly fine for years.

That said, being curious I thought the warning might also tell me where in the .s file it thought there was a problem... alas no information was provided that might lead me to understand what was going on.

Which leads to the cheeky question: Other than getting my attention, what's this trying to do?

[vince]

Genma Saotome, on 17 January 2015 - 10:04 PM, said:

With V2797 I'm seeing a lot of warning messages of "System.IndexOutOfRangeException: Index was outside the bounds of the array" followed by a failure to display a shape -- a shape that's been displaying since day 1. Many shapes actually.

I've no problem w/additional checks but I do object to failing to display stuff that's been displaying perfectly fine for years.

That said, being curious I thought the warning might also tell me where in the .s file it thought there was a problem... alas no information was provided that might lead me to understand what was going on.

Which leads to the cheeky question: Other than getting my attention, what's this trying to do?

Ditto here at X2800 on grabbing my attention.
The LIRR Budd RDC is now invisible. The diesel smoke however still shows up nicely as do the headlights and cabview. Many of the custom shapes I constructed using SketchUp are gone! Shapes as simple as a small 12 poly sign. I see it complaining about nits in shape files mostly.

vince

[Genma Saotome]

Yeah, that's about right.

Warnings are suppose to warn only and load the shape anyways. I expect it'll get corrected right away. But I would like to know what it caught its toe on when it stumbled.

[Jeffrey Kraus-Yao]

Erased.

[gpz]

Jeffrey Kraus-Yao, on 18 January 2015 - 01:19 AM, said:

When I wrote these checks I had to intentionally create broken shapes since none of my default routes had broken shapes.

I would wonder, who and when gave you svn access, and how you felt yourself free to commit code that was communicated by the development team for a long time as non-wanted behavior, without trying to make the consent first. Can you please answer these questions?

[Jeffrey Kraus-Yao]

Erased.

[James Ross]

Genma Saotome, on 17 January 2015 - 10:04 PM, said:

With V2797 I'm seeing a lot of warning messages of "System.IndexOutOfRangeException: Index was outside the bounds of the array" followed by a failure to display a shape -- a shape that's been displaying since day 1. Many shapes actually.

Dave, can we have a log file please? System.IndexOutOfRangeException is not the exception you get when code has found a problem with a shape, it's one that happens when there's a bug in the code, so we need to know where it is to fix it.

[James Ross]

I have made all the shape checks into pure warnings in X2802, so they won't prevent any shapes loading. Some of the checks are good, in that they prevent Open Rails crashing and hanging later, but we need to figure out which criteria are strictly necessary for that and which are just to aid in producing good shape files.

We still need Dave's log file to see what's up with the System.IndexOutOfRangeException, although I might have fixed that in X2801.

[Genma Saotome]

James Ross, on 18 January 2015 - 03:04 AM, said:

We still need Dave's log file to see what's up with the System.IndexOutOfRangeException, although I might have fixed that in X2801.

Here it is. I'll provide Jeff some files later this morning after I've had my coffee and can figure out what to forward.

 Open Rails - X2799 - 1.17.2015 9.49.36 PM.txt.zip (6.9K)
Number of downloads: 218

[Jeffrey Kraus-Yao]

Erased.

[James Ross]

Genma Saotome, on 18 January 2015 - 09:05 AM, said:

Here it is. I'll provide Jeff some files later this morning after I've had my coffee and can figure out what to forward.

Open Rails - X2799 - 1.17.2015 9.49.36 PM.txt.zip

Thanks, that looks to me like it is a shape with no entries in shape.lod_controls - something we actually check for elsewhere in OR but wasn't checked for in this new code until X2801.

Like Jeffrey says, it is worth running it again in the latest version (at least X2802) to check it now loads everything okay and also to see what warnings are logged.

[Genma Saotome]

James Ross, on 18 January 2015 - 09:58 AM, said:

Thanks, that looks to me like it is a shape with no entries in shape.lod_controls - something we actually check for elsewhere in OR but wasn't checked for in this new code until X2801.

Like Jeffrey says, it is worth running it again in the latest version (at least X2802) to check it now loads everything okay and also to see what warnings are logged.

And that makes sense for some of the failed items... I do set up a list of values I'm most likely to use but do not go back and delete those I have not used -- there's actually no function available to show me what was used vs. not used.

But I do wonder if there is something else going on as some of the shape names I notices do not have any LOD's set.

[Genma Saotome]

Ok, ran the latest version, things display but there is a large number of warning messages... as best as I can tell they all take this form:

Quote

Warning: Missing UV index in vertex 94 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 95 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 96 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 97 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 98 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 99 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 100 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 101 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 102 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 103 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 104 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 105 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 106 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 107 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Warning: Missing UV index in vertex 108 in sub-object 0 in distance level 0 in shape e:\bin\open rails 1930-1952\routes\cal-p\shapes\sp_rba_1t_0090r01dc_nm.s

Here is the .s, .sd, and Sketchup file for one such item, provided for OR Team testing only:
 MSTS.zip (1.1MB)
Number of downloads: 192

[Genma Saotome]

Looking at the SU file I believe it is safe to say that all instances of this problem are due to 1 to n untextured polys.

Which, of course, begs the question: How does a shape w/ untextured polys get placed in the world? The answer is via an editor. There is nothing magical about the contents of a UiD() entry in a world file and there are many, many situations where not only is it easier and faster to add such entries via an editor there are situations where it is the only means of adding an entry -- RE will fail when confronted with any shape holding > 10K polys.

Seeing as there is no texture there are also no UV entries and w/o any UV entries any index to same will be out of bounds.

For my two cents this is a "this can be ignored" situation. SU excels at producing faces w/o telling you; If you are a diligent modeler you use the provided function to track them down and either texture them or delete them... but it tends to be difficult when the face spans an area of 0.0001mm and the model covers 100k sq m. -- just ask Craig Kawahara (a.k.a. CKawahara here at ET) how many days in the past week have been spent trying to find and delete such things.

That said, there is always room for improvement and I believe a small tweek to the Ruby code is possible that would make finding and deleting such faces far easier. If there is any volunteer who will look at the code I can point them in the right direction.

[vince]

Jeffrey Kraus-Yao, on 18 January 2015 - 01:19 AM, said:

The checks I added for shapes were only expected to catch serious errors in shape files. If a simple 12-poly sign is causing these checks to not display the shape that means there are serious errors in the shape exporter for SketchUp. When I wrote these checks I had to intentionally create broken shapes since none of my default routes had broken shapes.

Could I get some of these broken shapes to examine? The source SketchUp files and the created .s files to examine? Also, what version of Sketchup are you using? I have the Ruby source code to examine included with the exporter. ..................snip.........................."

In the attached 12PolySign_ORBarf.zip is a clip from the OR Log where it barfed on the sign, a copy of the sign shape file and the single .ace file. If the entire log is wanted I'll be happy to attach the entire 355kb log text file.

I constructed the sign with SU 5 and exported it with version 2.0 of Pauls SU exporter.
I give permission to anyone who wants the enclosed sign shape to be be ripped, rapped, reamed, stolen, sold, peddeled, folded, spindled and mutilated by anyone who wants it.:rotfl:

Regards,
vince
edit add :sign_oops: the SketchUp source file.
v

Attached File(s)

•  12PolySign_ORBarf.zip (66.44K)
  Number of downloads: 168
•  LIRR_Sign_DangerHV~skp.zip (47.15K)
  Number of downloads: 175