[copperpen]

Peter

In MSTS, it matters not if the brake is non-lap or self lap. Using the 0 in the notch data denotes it is a notch and a keypress moves the control, but if the key is held down the control animation actually stops long enough to release the key. This movement is too fast in OR and although the control animation does stop, the time it stops is not long enough to allow a key release before moving again. That is why I suggested adding a time delay.

[atsf37l]

OK, let me weigh in here. Peter, you are correct in noting that the line 4 shows SelfLapping but all brakes in MSTS show that value in the 'control' language. It is how the sim's airbrake statements up higher in the .eng file are configured that determine whether the brakes are self lapping or non-self lapping.

Further, here's the deal on 'Running.' In the real world 'Running' is a position that you can move to that will stop charging the brakes - as moving from Release to Running. There's no functional reason for it the way MSTS/OR brakes work but prototypically it should be there. The problem with OR's Running position is that it releases and recharges the brakes just like 'Release.' It shouldn't do that.

Copperpen you are spot on in your analysis in Post #21. There is a noticeable delay in 2656 when moving through Lap, but it is so short that it is way too easy still to slip to Running and accidentally release the air.

We're getting closer guys! :)

[gpz]

Herb, I am not aware of the other option in .eng file you mention. Probably that is not parsed by OR at all. Could you please hint what is that other option that clearly determines whether the brake is self- or non-self lapped? By the way (also) a valid configuration is to enter

Notch(0.4 0 TrainBrakesControllerLapStart )

as a notch configuration to set the brakes as non-self-lapped, and this kind of config is being respected by OR in its current state too.

copperpen, on 21 November 2014 - 12:01 PM, said:

This movement is too fast in OR and although the control animation does stop, the time it stops is not long enough to allow a key release before moving again.

You are right, the controller speed is traditionally different in OR compared to MSTS. The difference is because MSTS seem to differentiate the notching speed based on [controller type / locomotive type / eng configuration / whatever], while OR handles all types of controls and all configurations with the same speed (of course by respecting the speed multiplier parameter, 3rd number in e.g. Brake_Train() section). That's why we see some controllers are slower in OR than in MSTS, and some others are faster. I personally have absolutely no patience to start analyzing MSTS behavior in this aspect and writing a table of all possible combinations, so that it can be reproduced the same way in OR. So unless someone does this work, and suggests a set of percent-per-second for all different cases, the notch configuration in .eng file must be adjusted for using in OR. There is no additional time delay needed to be added into the OR program code either, because if someone feels the changing speed too high, he can adjust the .eng Brake_Train() section himself.

I am willing to remove all brake line pressure changes for "Running" notch anyway, and I might add the decent stop to self-lapping-brakes too and/or try to make use of "the other" option Herb mentioned, once I will know which one that is. :) Just let me know witch behavior you want to be included to OR.

[atsf37l]

Peter, I misspoke. I thought there was a controlling statement up in the TrainBrake section but that is not the case. What distinguishes self lapping from non self lapping brakes in MSTS is the Lap Notch statement. Here's an example of essentially the same Rick Grout PA in the two different configurations: This is the Train Brake setup on a Southern Pacific PA passenger diesel from 3DTrainStuff with non self lapping brakes - similar to our steam loco's setting:

Brake_Train ( 0 1 0.0125 0.15
NumNotches ( 5
Notch( 0 0 TrainBrakesControllerReleaseStart )
Notch( 0.143 0 TrainBrakesControllerSelfLapStart )
Notch( 0.286 1 TrainBrakesControllerApplyStart )
Notch( 0.786 0 TrainBrakesControllerContinuousServiceStart )
Notch( 0.900 0 TrainBrakesControllerEmergencyStart )

This is the Train Brake setup on a Santa Fe PA passenger diesel from 3DTrains with self lapping brakes:

Brake_Train ( 0 1 0.0125 0.45
NumNotches ( 5
Notch( 0 0 TrainBrakesControllerReleaseStart )
Notch( 0.3 1 TrainBrakesControllerGraduatedSelfLapLimitedHoldingStart )
Notch( 0.85 0 TrainBrakesControllerSuppressionStart )
Notch( 0.9 0 TrainBrakesControllerContinuousServiceStart )
Notch( 0.95 0 TrainBrakesControllerEmergencyStart )

It is the TrainBrakesControllerGraduatedSelfLapLimitedHoldingStart statement that makes this second unit equipped with self lapping brakes.

If it is TrainBrakesControllerSelfLapStart then it is non self lapping.

[gpz]

Looking closely into the OpenRails code how the different notches are handled, I can see that

1. GraduatedSelfLapLimitedHoldingStart, SuppressionStart and ContinuousServiceStart does exactly the same thing.
2. SelfLapStart has no effect at all, as if the controller was in Neutral state.
3. Running notch seems to be modelled more or less correctly, when it is a smooth notch. It might have problems only in case it is a discrete one. In smooth case the closer the notch is to 100%, the less it releases the brake, and even at 0% state it releases the brake only 0.1 times the normal. (I admit it could be modelled more precisely though.)

[atsf37l]

gpz, on 24 November 2014 - 12:31 AM, said:

Looking closely into the OpenRails code how the different notches are handled, I can see that

1. GraduatedSelfLapLimitedHoldingStart, SuppressionStart and ContinuousServiceStart does exactly the same thing.
2. SelfLapStart has no effect at all, as if the controller was in Neutral state.
3. Running notch seems to be modelled more or less correctly, when it is a smooth notch. It might have problems only in case it is a discrete one. In smooth case the closer the notch is to 100%, the less it releases the brake, and even at 0% state it releases the brake only 0.1 times the normal. (I admit it could be modelled more precisely though.)

1. Correct, all essentially the same just more of it as you progress through the steps.
2. Correct again - status quo is it's intent: Reduce no more air and hold everything in check.
3. Running should not release air at all. It is the same to "Release" as Lap is to "Apply." When the engineer wants to stop charging the air reservoirs in the train and build up his main reservoir pressure he can move the lever from Release to Running. Add no more air and hold everything in check.

If Running did that then this discussion would be academic since it would give another status quo notch on the quadrant and if you accidentally slipped from Lap into Running you wouldn't lose your brake set. You would then achieve full MSTS compatibility with non self lapping brakes.

[gpz]

All right, then almost everything is fine. :sweatingbullets: Sorry for the delay, today I will have time to make the modification. Anyway, your example notch configs don't have a Running state defined. :derisive:

[copperpen]

TrainBrakesControllerRunningStart is the control notch that is missing in those two examples from Herb. Here is a full list of brake controller lines from MSTS;

TrainBrakesControllerFullQuickReleaseStart
TrainBrakesControllerGraduatedQuickReleaseStart
TrainBrakesControllerReleaseStart
TrainBrakesControllerHoldStart
TrainBrakesControllerEPApplyStart
TrainBrakesControllerEPHoldStart
TrainBrakesControllerRunningStart
TrainBrakesControllerSelfLapStart
TrainBrakesControllerGraduatedSelfLapStart
TrainBrakesControllerGraduatedSelfLapLimitedStart
TrainBrakesControllerNeutralhandleOffStart
TrainBrakesControllerMinimalReductionStart
TrainBrakesControllerApplyStart
TrainBrakesControllerFullServiceStart
TrainBrakesControllerSuppressionStart
TrainBrakesControllerContinuousServiceStart
TrainBrakesControllerEmergencyStart

To define notches that do not have any specific function, but simply act as détentes within a range, name the notches “dummy”.
The order these are in is important. If they do not occur in this order then the controller will not work properly. A selection of these is normally used.

I think HoldStart could also be used in the same way as RunningStart.

The engine brake uses the same notch types, with Engine substituted for Train.

[gpz]

I disabled any pressure line change for "Running" notch state in r2668.

[atsf37l]

gpz, on 24 November 2014 - 02:16 AM, said:

All right, then almost everything is fine. :) Sorry for the delay, today I will have time to make the modification. Anyway, your example notch configs don't have a Running state defined. :)

Right, they were both for diesels, on with and one without self lapping brakes. Steam, using the older K6 type of brake had the running application. MSTS steam loco brakes were posted above and are like so:

Brake_Train ( 0 1 0.1 0
NumNotches( 6
Notch(0 0 TrainBrakesControllerReleaseStart )
Notch(0.2 0 TrainBrakesControllerRunningStart )
Notch(0.4 0 TrainBrakesControllerSelfLapStart )
Notch(0.5 1 TrainBrakesControllerApplyStart )
Notch(0.9 0 TrainBrakesControllerFullServiceStart )
Notch(1.0 0 TrainBrakesControllerEmergencyStart )

Going to give 2668 a look-see.