[gpz]

Carlo,

I think if

var xd = (x.XNAMatrix.Translation - XNAViewerPos).Length() - x.RenderPrimitive.SortIndex;

fails, then the most possible cause is that x.RenderPrimitive is null, or something similar.

[Csantucci]

This is what I have traced after the exception:

arning: Exception message = IComparer (o i metodi IComparable su cui questo si basa) non ha restituito zero quando Array.Sort ha chiamato x.CompareTo(x).  x: ''. Tipo di x: 'RenderItem'. IComparer: 'ORTS.Viewer3D.RenderItem+Comparer'.

Warning: sequenceMaterial.Key = EmptyMaterial, sequenceMaterial.Value.Count = 4, renderItemComparer.XNAViewerPos = {X:-566,4696 Y:562,159 Z:46,89798}

Warning: sequenceMaterial.Value[0].Material = SceneryMaterial(c:\saveroutes\train simulator bernina\trains\trainset\rhb_ew_iv\\pass_glas.ace:00000005:0) ,  sequenceMaterial.Value[0].RenderPrimitive.SortIndex = 21, sequenceMaterial.Value[0].XNAMatrix.Translation = {X:-565,4244 Y:562,8322 Z:50,28863}

Warning: sequenceMaterial.Value[1].Material = SceneryMaterial(c:\saveroutes\train simulator bernina\trains\trainset\rhb_ew_iv\\pass_glas.ace:00000005:0) ,  sequenceMaterial.Value[1].RenderPrimitive.SortIndex = 19, sequenceMaterial.Value[1].XNAMatrix.Translation = {X:-567,3919 Y:562,8322 Z:47,30493}

Warning: sequenceMaterial.Value[2].Material = SceneryMaterial(c:\saveroutes\train simulator bernina\trains\trainset\rhb_ew_iv\\pass_glas.ace:00000005:0) ,  sequenceMaterial.Value[2].RenderPrimitive.SortIndex = 20, sequenceMaterial.Value[2].XNAMatrix.Translation = {X:-566,4082 Y:562,8322 Z:48,79678}

Warning: sequenceMaterial.Value[3].Material = SceneryMaterial(c:\saveroutes\train simulator bernina\trains\trainset\rhb_ew_iv\\pass_glas.ace:00000005:0) ,  sequenceMaterial.Value[3].RenderPrimitive.SortIndex = 22, sequenceMaterial.Value[3].XNAMatrix.Translation = {X:-565,4244 Y:562,8322 Z:50,28863}

I don't see strange things, apart from the fact that the position of the first and the last object is the same.
This is the full log
 OpenRailsLog_sort.zip (3.5K)
Number of downloads: 309

I have made a basic and working proposal for solution. I don't have other ones and give up.

PS: Peter, I have seen now your hint, thank you very much. However, looking at the data I have collected, that does not seem the case.

[James Ross]

Csantucci, on 12 April 2014 - 02:13 PM, said:

I don't see strange things, apart from the fact that the position of the first and the last object is the same.

That is exactly why we have the SortIndex, to ensure such items are always drawn in the correct order. :sign_thanks:

[Csantucci]

This patch here avoids the crash and uses the original comparing algorithm. The comparison has only been compacted. I hope it can be accepted
 RenderFrame.cs.patch.zip (406bytes)
Number of downloads: 294

[gpz]

:) Interesting! This is the evil in the machine. :)
(I'm just wondering if the Math.Sign() is necessary there. I think it can be removed to save a couple of CPU instructions, since for compare it doesn't matter if the result is e.g. 1 or 8526. No need to normalize.)

[Csantucci]

Yes, I really think I found something a bit evil :) ; referring to Math.Sign() I tried to remove it, but the fact is that the result must be an integer, else C# complains. So I think it's faster to derive a sign than to make a conversion, and therefore I would leave the Math.Sign().

[Csantucci]

Hello fastlars,
my patch can make miracles, however, before explaining how to use the patch, I attach here a runactivity.exe related to release 2176 and patched with the above patch. Check it by replacing the runactivity.exe you have, and if your problem is solved, we can go some step further :)
 RunActivity.zip (512.93K)
Number of downloads: 308

[James Ross]

fastlars, on 13 April 2014 - 12:55 PM, said:

Conclusion: Your edited Version works fine without runactivityLAA.exe in the folder.

I suspect you've enabled the "Use large address aware binaries" option, which causes RunActivityLAA to be preferred to RunActivity, confusing your testing.