[ostkamp]

Hello,

here are some more parsing errors that would need fixing (tested with OR1309):

***

Warning: Found a suffix 'bar' which could not be parsed as a Pressure unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 38 DB RB63\GR_DB_38_2818.eng:line 254

That line reads

BoilerVolume ( "7.7*(m^3)" )

***

Warning: Found a suffix 'bar' which could not be parsed as a Pressure unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_191_VZ.eng:line 268

That line reads

MaxBoilerPressure ( 16bar )

***

Warning: Skipped unknown notch type EngineBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_191_VZ.eng:line 352

That line reads
Notch(0.1 0 EngineBrakesControllerNeutralhandleOffStart)

***

Warning: Cannot parse the constant number -0.04-2.1035 in c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\au1000_xx.sd:line 6

That line reads

ESD_Bounding_Box ( -0.8225 -0.04-2.1035 0.8225 1.367 2.1035 )

***

Also there are multiple occurrences of

Warning: Unknown parameter in statement : RETURN

but it does not tell any details (file, line number etc.)


Full error log:

Open Rails is starting...

Version = X.1309
Build = 0.0.4682.30625 2012/10/26 ���� 18:12
Logfile = c:\dokumente und einstellungen\guido ostkamp\anwendungsdaten\open rails\testinglog.txt
--------------------------------------------------------------------------------
Alerter = False
AvatarURL = http://openrails.org...pport-logos.jpg
BrakePipeChargingRate = 21
BreakCouplers = False
Cab2DStretch = 0
DataLogger = False
DynamicShadows = False
FullScreen = (registry) True
GraduatedRelease = (registry) True
Logging = True
LoggingFilename = (command-line) testinglog.txt
LoggingPath = (command-line) c:\dokumente und einstellungen\guido ostkamp\anwendungsdaten\open rails
Menu_Selection = (registry) C:\Programme\Microsoft Games\Train Simulator, C:\Programme\Microsoft Games\Train Simulator\ROUTES\PTAKR, C:\Programme\Microsoft Games\Train Simulator\ROUTES\PTAKR\ACTIVITIES\PT10-ICE-A-K-P4.act
MSTSBINSound = False
Multiplayer = False
Multiplayer_Host = (registry)
Multiplayer_Port = 30000
Multiplayer_UpdateInterval = 10
Multiplayer_User = (registry)
MultiplayerClient = False
MultiplayerServer = False
Precipitation = (registry) True
Profiling = (command-line) True
ProfilingFrameCount = 0
ProfilingTime = (command-line) 10
ScreenshotPath = C:\Dokumente und Einstellungen\Guido Ostkamp\Eigene Dateien\Eigene Bilder\Open Rails
ShaderModel = 0
ShadowAllShapes = False
ShadowMapBlur = True
ShadowMapCount = 4
ShadowMapDistance = 0
ShadowMapResolution = 1024
ShowAvatar = False
ShowErrorDialogs = (command-line) False
SoundDetailLevel = 5
SoundVolumePercent = 100
SuppressConfirmations = False
TrainLights = (registry) True
UseAdvancedAdhesion = True
VerticalSync = False
ViewDispatcher = False
ViewingDistance = 2000
ViewingFOV = 45
WindowGlass = (registry) True
WindowPosition_Activity = 50, 50
WindowPosition_Compass = 50, 0
WindowPosition_ComposeMessage = 50, 50
WindowPosition_DriverAid = 100, 100
WindowPosition_Help = (registry) 8, 54
WindowPosition_NextStation = 0, 100
WindowPosition_Quit = 50, 50
WindowPosition_Switch = 0, 50
WindowPosition_TrackMonitor = 100, 0
WindowPosition_TrainOperations = 50, 50
WindowSize = (registry) 1280x1024
Wire = (registry) True
WorldObjectDensity = 10
--------------------------------------------------------------------------------
Mode = Test Activity
Activity = C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\ACTIVITIES\01-Eilzug.act
--------------------------------------------------------------------------------
Loading TRK TDB SIGCFG

Warning: Skipped duplicate SignalDrawState green in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\sigcfg.dat:line 467

Warning: 1 missing SignalDrawState(s) in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\sigcfg.dat:line 468

Warning: Skipped duplicate SignalDrawState green in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\sigcfg.dat:line 516

Warning: 1 missing SignalDrawState(s) in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\sigcfg.dat:line 517

DAT

Warning: Replaced duplicate TrackSection 360 in C:\Programme\Microsoft Games\Train Simulator\GLOBAL\TSECTION.DAT:line 1455

ACT RDB CARSPAWN SIGSCR

Warning: Unknown parameter in statement : RETURN

Warning: Unknown parameter in statement : RETURN

ADMIN EDIT: Saying lots more is enough of an explaination
<<many identical lines deleted as a courtesy to readers>>


WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW



Warning: Found a suffix '*(m^3)' which could not be parsed as a Volume unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_191_VZ.eng:line 252

Warning: Found a suffix 'bar' which could not be parsed as a Pressure unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_191_VZ.eng:line 268

Warning: Skipped unknown notch type EngineBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_191_VZ.eng:line 352

Warning: Skipped unknown notch type TrainBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_191_VZ.eng:line 362

Warning: Found a suffix 'bar' which could not be parsed as a Pressure unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 01_DB\01_1057.eng:line 343

Warning: Skipped unknown notch type EngineBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 01_DB\01_1057.eng:line 433

Warning: Skipped unknown notch type TrainBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 01_DB\01_1057.eng:line 443

Warning: Found a suffix 'bar' which could not be parsed as a Pressure unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 38 DB RB63\GR_DB_38_2818_VZ.eng:line 267

Warning: Found a suffix 'bar' which could not be parsed as a Pressure unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 01_DB\01_1057_VZ.eng:line 246

Warning: Found a suffix 'bar' which could not be parsed as a Pressure unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 44 DB RB63\GR_DB_44_085_VZ.eng:line 310

Warning: Some of this STF file was not parsed. in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 44 DB RB63\GR_DB_44_085ten.wag:line 118

Warning: Found a suffix 'bar' which could not be parsed as a Pressure unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 44 DB RB63\GR_DB_44_431_VZ.eng:line 311

Warning: Found a suffix '*(m^3)' which could not be parsed as a Volume unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_2696_VZ.eng:line 253

Warning: Found a suffix 'bar' which could not be parsed as a Pressure unit in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_2696_VZ.eng:line 269

Warning: Skipped unknown notch type EngineBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_2696_VZ.eng:line 353

Warning: Skipped unknown notch type TrainBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 50 DB RB63\GR_BR_50_2696_VZ.eng:line 363

ENV SIGCFG

Warning: Skipped duplicate SignalDrawState green in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\sigcfg.dat:line 467

Warning: 1 missing SignalDrawState(s) in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\sigcfg.dat:line 468

Warning: Skipped duplicate SignalDrawState green in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\sigcfg.dat:line 516

Warning: 1 missing SignalDrawState(s) in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\sigcfg.dat:line 517

TTYPE

Information: OpenAL using device DirectSound

TTTTTTTTTWSSSSSSSSSSSSSSS TRP(default)SSSSSSSSS

Warning: Skipped {TileX:-5773 TileZ:14963 X:-19,4878 Y:73,1504 Z:980,585} signal 1596 unit 0 with sub-object SCHIRM which is missing from shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\kn2sig_lsp01_o.s

Warning: Skipped {TileX:-5773 TileZ:14963 X:-19,4878 Y:73,1504 Z:980,585} signal 1596 unit 1 with sub-object SCHIRM which is missing from shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\kn2sig_lsp01_o.s

Warning: Skipped {TileX:-5773 TileZ:14963 X:-19,4878 Y:73,1504 Z:980,585} signal 1596 unit 2 with sub-object SCHIRM which is missing from shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\kn2sig_lsp01_o.s

<<many identical lines deleted as a courtesy to readers>>
SSSSSSSSSSSSSSS$WSSSS

Warning: Skipped unknown shader name Diffuse first seen in shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\hf_1.s

Warning: Skipped unknown lighting model index 0 first seen in shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\hf_1.s

SSSS$WWWSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

Warning: Skipped {TileX:-5772 TileZ:14964 X:325,631 Y:70,0258 Z:-149,761} signal 1960 unit 0 with sub-object MAIN which is missing from shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\kn2sig_sh0.s

Warning: Skipped {TileX:-5772 TileZ:14964 X:325,631 Y:70,0258 Z:-149,761} signal 1960 unit 1 with sub-object MAIN which is missing from shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\kn2sig_sh0.s

Warning: Skipped {TileX:-5772 TileZ:14964 X:325,631 Y:70,0258 Z:-149,761} signal 1960 unit 2 with sub-object MAIN which is missing from shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\kn2sig_sh0.s

Warning: Skipped {TileX:-5772 TileZ:14964 X:325,631 Y:70,0258 Z:-149,761} signal 1960 unit 3 with sub-object MAIN which is missing from shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\kn2sig_sh0.s

Warning: Skipped {TileX:-5772 TileZ:14964 X:325,631 Y:70,0258 Z:-149,761} signal 1960 unit 4 with sub-object MAIN which is missing from shape c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\kn2sig_sh0.s

<<many identical lines deleted as a courtesy to readers>>
SSSSSSSS$CSS

Warning: 1 missing Stream(s) in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\SOUND\GR_8Ex.sms:line 124

Warning: 1 missing Stream(s) in C:\Programme\Microsoft Games\Train Simulator\ROUTES\ROLLBAHN2\SOUND\GR_9Ex.sms:line 128

CSSCSCSCSCCS

Warning: Cannot parse the constant number -0.04-2.1035 in c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\au1000_xx.sd:line 6

Warning: Cannot parse the constant number ) in c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\au1000_xx.sd:line 6

SSS



Regards

Guido

[wacampbell]

Hello Guido,

Thanks for the report. It would be more helpful if you could verify that the warning is actually incorrect before you report it as a bug. For example:

BoilerVolume ( "7.7*(m^3)" )

MaxBoilerPressure ( 16bar )

Notch(0.1 0 EngineBrakesControllerNeutralhandleOffStart)

ESD_Bounding_Box ( -0.8225 -0.04-2.1035 0.8225 1.367 2.1035 )


These are all improperly formed statements. Most likely MSTS just ignores the statement entirely, using some predefined default, resulting in a behavior that wasn't intended.

OR will also proceed with using the file with a default value, but OR also gives you a warning that the line is incorrect. This is not a bug in OR, its a mistake in the .eng file and OR is properly warning you about it so you can fix it.

We appreciate all feedback, but its much more valuable if you can help us verify that it is truely a bug so that we don't end up chasing things that are not a problem.

[Genma Saotome]

I'd like to add that most, if not all OR warnings fall into one of two categories:

• If the warning line has "Skipped Unknown" near the start and also has ".cvf" near the end it usually means there is a cab feature present that the Open Rails team has not yet implemented. This can also occur in the .eng file. LOOK at the warning text: You should be able to tell if it was a cab feature or not. Your patience in the matter will be appreciated.
  
• Almost all others are going to be something odd in the MSTS data file that MSTS ignored. See Wayne's message, above.

Anything that begins with ERROR should not be happening. Sometimes we already know about it but havn't fixed it yet. Sometimes it's new. Please report these.

[ostkamp]

Hello,

wacampbell, on 01 November 2012 - 07:26 AM, said:

Thanks for the report. It would be more helpful if you could verify that the warning is actually incorrect before you report it as a bug. For example:
[...]
These are all improperly formed statements. Most likely MSTS just ignores the statement entirely, using some predefined default, resulting in a behavior that wasn't intended.

thanks for your reponse, it's much appreciated :-)

I must admit that while I am a professional software developer in the Unix/Linux world, I don't know anything about MSTS file formats.

Here in Germany we have many commercial products like "German Railroads Mega Collection" etc. and I supposed these had been created by professional MSTS designers using some specialized tools or IDE, so I was not expecting any bad file format but assuming an OR error.

Nevertheless, you said "most likely" MSTS ignores those statements as well. If you are really sure, then ok.

But if MSTS still interprets those values (and I know from my IT experience, that such reading input up to the next character that doesn't fit to e.g. a number format is not uncommon) then OR would fail the target to get as much existing MSTS content running as possible, if it just ignores the setting. In this case it would be better to implement a more "relaxed" reading of configuration data and tolerate those formats.

Anyway, I will stop bothering you with that kind of warnings until futher notice, and focus on errors and display problems.

You haven't commented on the "RETURN" issue, so I am assuming it also belongs to the above category. I cannot get you a line here, since the debug message did not include line number and file name.

Could you please at least enhance that warning?

Regards

Guido

[cjakeman]

ostkamp, on 01 November 2012 - 10:31 AM, said:

You haven't commented on the "RETURN" issue, so I am assuming it also belongs to the above category. I cannot get you a line here, since the debug message did not include line number and file name.

Could you please at least enhance that warning?

I'm not comfortable with that message either. We can't take a copy of your files because they're commercial, but perhaps we can tweak OR and get you to try again.

I will post to this thread later.

[ostkamp]

Hello,

cjakeman, on 01 November 2012 - 11:25 AM, said:

I'm not comfortable with that message either. We can't take a copy of your files because they're commercial, but perhaps we can tweak OR and get you to try again.

I will post to this thread later.

I can retry with any tweaked OR version and look up file contents anytime, if that provides the necessary info for you.
You just need to drop me a link to the changed version or patch. I have the latest unofficial one installed here (1309).
Please take into account the timezone when waiting for a reply (I am in Germany here, which is GMT+1, which means at the time of writing this it's already 23:09h local time).

Regards

Guido

[cjakeman]

ostkamp, on 01 November 2012 - 07:06 AM, said:

Warning: Skipped unknown notch type EngineBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 01_DB\01_1057.eng:line 433

Warning: Cannot parse the constant number -0.04-2.1035 in c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\au1000_xx.sd:line 6

I think the error messages are very helpful (and I can see why Microsoft preferred to ignore most errors :-)

Would there be any harm in changing the wording? I was thinking the 2 messages above might become:

Not Implemented Warning: Skipped notch type EngineBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 01_DB\01_1057.eng:line 433

Bad Data Warning: Cannot parse the constant number -0.04-2.1035 in c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\au1000_xx.sd:line 6

Would it cause any problems if I did this?

[ostkamp]

Hello again,

wacampbell, on 01 November 2012 - 07:26 AM, said:

BoilerVolume ( "7.7*(m^3)" )
MaxBoilerPressure ( 16bar )
Notch(0.1 0 EngineBrakesControllerNeutralhandleOffStart)
ESD_Bounding_Box ( -0.8225 -0.04-2.1035 0.8225 1.367 2.1035 )

These are all improperly formed statements. Most likely MSTS just ignores the statement entirely, using some predefined default, resulting in a behavior that wasn't intended.

I found the English language document MSTS Eng. & Wag. Manual 2.0e from Rudolf Richter (download available on that page) that explains lots of such parameters. In that document e.g. the MaxBoilerPressure stuff is listed with "bar" being supported as pressure unit, also such example is given later in the document.

Are you really sure that this value is incorrect?

Regards

Guido

[James Ross]

cjakeman, on 02 November 2012 - 12:14 AM, said:

I think the error messages are very helpful (and I can see why Microsoft preferred to ignore most errors :-)

Would there be any harm in changing the wording? I was thinking the 2 messages above might become:

Not Implemented Warning: Skipped notch type EngineBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 01_DB\01_1057.eng:line 433

Bad Data Warning: Cannot parse the constant number -0.04-2.1035 in c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\au1000_xx.sd:line 6

Would it cause any problems if I did this?

Yes, that would screw up log parsing and break the standard logging formatting. Change the message if you must but not the format.

And the problem here is that unimplemented items should be Information, not Warning.

[cjakeman]

James Ross, on 02 November 2012 - 09:37 AM, said:

Yes, that would screw up log parsing and break the standard logging formatting. Change the message if you must but not the format.

And the problem here is that unimplemented items should be Information, not Warning.

Thanks, James.

The following would be compatible, then, and now shows OR's position regarding the message.

Information: Not implemented - skipped notch type EngineBrakesControllerNeutralhandleOffStart in C:\Programme\Microsoft Games\Train Simulator\trains\trainset\GR-BR 01_DB\01_1057.eng:line 433

Warning: Bad data - cannot parse the constant number -0.04-2.1035 in c:\programme\microsoft games\train simulator\routes\rollbahn2\shapes\au1000_xx.sd:line 6